r47615 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r47614‎ | r47615 | r47616 >
Date:15:03, 21 February 2009
Author:alnokta
Status:ok (Comments)
Tags:
Comment:
Fix bug 1061 CSS-added icons next to links display through the text and makes it unreadable in RTL

Patch by Ahmad Sherif
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/skins/common/wikibits.js (modified) (history)
  • /trunk/phase3/skins/monobook/FF2Fixes.css (added) (history)
  • /trunk/phase3/skins/monobook/IE60Fixes.css (modified) (history)
  • /trunk/phase3/skins/monobook/IE70Fixes.css (modified) (history)
  • /trunk/phase3/skins/monobook/Opera6Fixes.css (modified) (history)
  • /trunk/phase3/skins/monobook/Opera7Fixes.css (modified) (history)
  • /trunk/phase3/skins/monobook/Opera9Fixes.css (added) (history)
  • /trunk/phase3/skins/monobook/external-rtl.png (added) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)
  • /trunk/phase3/skins/monobook/rtl.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/Opera6Fixes.css
——@@ -12,3 +12,9 @@
1313 background: url(external.png) center right no-repeat;
1414 padding-right: 13px;
1515 }
 16+
 17+.rtl a.feedlink {
 18+ background-position: right;
 19+ padding-right: 0;
 20+ padding-left: 16px;
 21+}
Index: trunk/phase3/skins/monobook/Opera7Fixes.css
——@@ -9,3 +9,13 @@
1010 background: url(external.png) center right no-repeat;
1111 padding-right: 13px;
1212 }
 13+.rtl #bodyContent a.external {
 14+ background-image: url(external-rtl.png);
 15+ padding-right: 13px;
 16+}
 17+
 18+.rtl a.feedlink {
 19+ background-position: right;
 20+ padding-right: 0;
 21+ padding-left: 16px;
 22+}
Index: trunk/phase3/skins/monobook/Opera9Fixes.css
——@@ -0,0 +1,11 @@
 2+.rtl #bodyContent a.external {
 3+ background-image: url(external-rtl.png);
 4+ padding-right: 0;
 5+ padding-left: 13px;
 6+}
 7+
 8+.rtl a.feedlink {
 9+ background-position: right;
 10+ padding-right: 0;
 11+ padding-left: 16px;
 12+}
Property changes on: trunk/phase3/skins/monobook/Opera9Fixes.css
___________________________________________________________________
Added: svn:eol-style
113 + native
Index: trunk/phase3/skins/monobook/rtl.css
——@@ -147,11 +147,12 @@
148148 #p-personal li {
149149 float: left;
150150 }
151 -/* Fix link icons */
 151+/* Fix link icons
152152 .external, a.feedlink {
153153 padding: 0 !important;
154154 background: none !important;
155155 }
 156+*/
156157 #footer {
157158 clear: both;
158159 }
Index: trunk/phase3/skins/monobook/IE60Fixes.css
——@@ -61,6 +61,17 @@
6262 padding-right: 13px;
6363 }
6464
 65+.rtl #bodyContent a.external {
 66+ background-image: url(external-rtl.png);
 67+ padding-right: 13px;
 68+}
 69+
 70+.rtl a.feedlink {
 71+ background-position: right;
 72+ padding-right: 0;
 73+ padding-left: 16px;
 74+}
 75+
6576 /* show the hand */
6677 #p-logo a,
6778 #p-logo a:hover {
Index: trunk/phase3/skins/monobook/IE70Fixes.css
——@@ -18,6 +18,16 @@
1919 margin-top: 160px;
2020 }
2121
 22+.rtl #bodyContent a.external {
 23+ background-image: url(external-rtl.png);
 24+ padding: 0 13px 0 0;
 25+}
 26+
 27+.rtl a.feedlink {
 28+ background-position: right;
 29+ padding-right: 0;
 30+ padding-left: 16px;
 31+}
2232 /* the tabs */
2333
2434 #p-cactions {
Index: trunk/phase3/skins/monobook/FF2Fixes.css
——@@ -0,0 +1,4 @@
 2+.rtl .external, a.feedlink {
 3+ padding: 0 !important;
 4+ background: none !important;
 5+}
Property changes on: trunk/phase3/skins/monobook/FF2Fixes.css
___________________________________________________________________
Added: svn:eol-style
16 + native
Index: trunk/phase3/skins/monobook/external-rtl.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/skins/monobook/external-rtl.png
___________________________________________________________________
Added: svn:mime-type
27 + image/png
Index: trunk/phase3/skins/monobook/main.css
——@@ -527,32 +527,35 @@
528528 #bodyContent a.external,
529529 #bodyContent a[href ^="gopher://"] {
530530 background: url(external.png) center right no-repeat;
531 - padding-right: 13px;
 531+ padding: 0 13px;
532532 }
 533+.rtl #bodyContent a[href ^="http://"] {
 534+ background-image: url(external-rtl.png);
 535+}
533536 #bodyContent a[href ^="https://"],
534537 .link-https {
535538 background: url(lock_icon.gif) center right no-repeat;
536 - padding-right: 16px;
 539+ padding: 0 16px;
537540 }
538541 #bodyContent a[href ^="mailto:"],
539542 .link-mailto {
540543 background: url(mail_icon.gif) center right no-repeat;
541 - padding-right: 18px;
 544+ padding: 0 18px;
542545 }
543546 #bodyContent a[href ^="news://"] {
544547 background: url(news_icon.png) center right no-repeat;
545 - padding-right: 18px;
 548+ padding: 0 18px;
546549 }
547550 #bodyContent a[href ^="ftp://"],
548551 .link-ftp {
549552 background: url(file_icon.gif) center right no-repeat;
550 - padding-right: 18px;
 553+ padding: 0 18px;
551554 }
552555 #bodyContent a[href ^="irc://"],
553556 #bodyContent a.extiw[href ^="irc://"],
554557 .link-irc {
555558 background: url(discussionitem_icon.gif) center right no-repeat;
556 - padding-right: 18px;
 559+ padding: 0 18px;
557560 }
558561 #bodyContent a.external[href $=".ogg"], #bodyContent a.external[href $=".OGG"],
559562 #bodyContent a.external[href $=".mid"], #bodyContent a.external[href $=".MID"],
——@@ -562,7 +565,7 @@
563566 #bodyContent a.external[href $=".wma"], #bodyContent a.external[href $=".WMA"],
564567 .link-audio {
565568 background: url("audio.png") center right no-repeat;
566 - padding-right: 13px;
 569+ padding: 0 13px;
567570 }
568571 #bodyContent a.external[href $=".ogm"], #bodyContent a.external[href $=".OGM"],
569572 #bodyContent a.external[href $=".avi"], #bodyContent a.external[href $=".AVI"],
——@@ -570,16 +573,32 @@
571574 #bodyContent a.external[href $=".mpg"], #bodyContent a.external[href $=".MPG"],
572575 .link-video {
573576 background: url("video.png") center right no-repeat;
574 - padding-right: 13px;
 577+ padding: 0 13px;
575578 }
576579 #bodyContent a.external[href $=".pdf"], #bodyContent a.external[href $=".PDF"],
577580 #bodyContent a.external[href *=".pdf#"], #bodyContent a.external[href *=".PDF#"],
578581 #bodyContent a.external[href *=".pdf?"], #bodyContent a.external[href *=".PDF?"],
579582 .link-document {
580583 background: url("document.png") center right no-repeat;
581 - padding-right: 12px;
 584+ padding: 0 12px;
582585 }
583586
 587+/* for rtl wikis */
 588+.rtl #bodyContent a.external {
 589+ background-position: left;
 590+ padding-right: 0;
 591+}
 592+.rtl a.feedlink {
 593+ background-position: right;
 594+ padding-right: 16px;
 595+ padding-left: 0;
 596+}
 597+
 598+/* correction for ltr wikis */
 599+.ltr #bodyContent a.external {
 600+ padding-left: 0;
 601+}
 602+
584603 /* disable interwiki styling */
585604 #bodyContent a.extiw,
586605 #bodyContent a.extiw:active {
Index: trunk/phase3/skins/common/wikibits.js
——@@ -14,6 +14,7 @@
1515 ( document.childNodes && !document.all && !navigator.taintEnabled );
1616 // For accesskeys; note that FF3+ is included here!
1717 var is_ff2 = /firefox\/[2-9]|minefield\/3/.test( clientPC );
 18+var is_ff2_ = /firefox\/2/.test( clientPC );
1819 // These aren't used here, but some custom scripts rely on them
1920 var is_ff2_win = is_ff2 && clientPC.indexOf('windows') != -1;
2021 var is_ff2_x11 = is_ff2 && clientPC.indexOf('x11') != -1;
——@@ -91,8 +92,12 @@
9293 importStylesheetURI(stylepath+'/'+skin+'/Opera6Fixes.css');
9394 } else if (is_opera_seven && !is_opera_95) {
9495 importStylesheetURI(stylepath+'/'+skin+'/Opera7Fixes.css');
 96+ } else if (is_opera_95) {
 97+ importStylesheetURI(stylepath+'/'+skin+'/Opera9Fixes.css');
9598 } else if (is_khtml) {
9699 importStylesheetURI(stylepath+'/'+skin+'/KHTMLFixes.css');
 100+ } else if (is_ff2_) {
 101+ importStylesheetURI(stylepath+'/'+skin+'/FF2Fixes.css');
97102 }
98103 }
99104
Index: trunk/phase3/RELEASE-NOTES
——@@ -209,6 +209,7 @@
210210 * (bug 17538) Use shorter URLs in <link> elements
211211 * (bug 13778) Hidden input added to the search form so that using the Enter key
212212 on IE will do a fulltext search like clicking the button does
 213+* (bug 1061) CSS-added icons next to links display through the text and makes it unreadable in RTL
213214
214215 == API changes in 1.15 ==
215216 * (bug 16858) Revamped list=deletedrevs to make listing deleted contributions

Follow-up revisions

RevisionCommit summaryAuthorDate
r48409follow up on bug 1061alnokta15:36, 14 March 2009
r50102* (bug 18207) Strange spacing before [[irc:...]] links...danny_b10:31, 1 May 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   00:20, 17 March 2009

Follow-up in r48409

#Comment by Danny B. (talk | contribs)   10:33, 1 May 2009

Bug 18207 fixed in r50102.

#Comment by Danny B. (talk | contribs)   10:54, 3 May 2009

This revision also broke bug 3043 fix. Strongly suggesting to pull this revision back, it brought more issues than benefits.

#Comment by AhmadSherif (talk | contribs)   11:19, 3 May 2009

What is broken in bug 3043?

#Comment by Danny B. (talk | contribs)   14:17, 3 May 2009

The feed icon is no longer displayed.

#Comment by AhmadSherif (talk | contribs)   17:16, 3 May 2009

WORKSFORME then. It's displayed on about twenty wikis I picked randomly from Special:RecentChanges including English WP.

Status & tagging log