r47452 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47451‎ | r47452 | r47453 >
Date:16:00, 18 February 2009
Author:yaron
Status:deferred
Tags:
Comment:
Full header is no longer displayed if category has no subcategories or filters
Modified paths:
  • /trunk/extensions/SemanticDrilldown/specials/SD_BrowseData.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticDrilldown/specials/SD_BrowseData.php
@@ -772,6 +772,14 @@
773773 if (! $this->show_single_cat) {
774774 $header .= $this->printCategoriesList($categories);
775775 }
 776+ // if there are no subcategories or filters for this
 777+ // category, escape now that we've (possibly) printed the
 778+ // categories list
 779+ if ((count($this->next_level_subcategories) == 0) &&
 780+ (count($this->applied_filters) == 0) &&
 781+ (count($this->remaining_filters) == 0)) {
 782+ return $header;
 783+ }
776784 $header .= ' <div class="drilldown-header">' . "\n";
777785 if (count ($this->applied_filters) > 0 || $this->subcategory) {
778786 $category_url = $this->makeBrowseURL($this->category);

Status & tagging log