r47449 MediaWiki - Code Review archive

Repository:	MediaWiki
Revision:	< r47448‎ \| r47449 \| r47450 >
Date:	13:24, 18 February 2009
Author:	siebrand
Status:	deferred
Tags:
Comment:	Put link from 'g-back-link' in code. Taken out of the message.
Modified paths:	/trunk/extensions/SocialProfile/UserGifts/SpecialGiveGift.php (modified) (history) /trunk/extensions/SocialProfile/UserGifts/SpecialRemoveGift.php (modified) (history) /trunk/extensions/SocialProfile/UserGifts/SpecialViewGift.php (modified) (history) /trunk/extensions/SocialProfile/UserGifts/SpecialViewGifts.php (modified) (history) /trunk/extensions/SocialProfile/UserGifts/UserGifts.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SocialProfile/UserGifts/UserGifts.i18n.php
—	—	@@ -27,7 +27,7 @@
28	28	'g-add-message' => 'Add a message',
29	29	'g-back-edit-gift' => 'Back to edit this gift',
30	30	'g-back-gift-list' => 'Back to gift list',
31		~~- 'g-back-link' => '<a href="$1">< Back to $2\'s page</a>',~~
	31	+ 'g-back-link' => '< Back to $2\'s page',
32	32	'g-choose-file' => 'Choose file:',
33	33	'g-cancel' => 'Cancel',
34	34	'g-count' => '$1 has $2 {{PLURAL:$2\|gift\|gifts}}.',
—	—	@@ -148,7 +148,7 @@
149	149	'g-add-message' => 'أضف رسالة',
150	150	'g-back-edit-gift' => 'رجوع لتعديل هذه الهدية',
151	151	'g-back-gift-list' => 'رجوع لقائمة الهدايا',
152		~~- 'g-back-link' => '<a href="$1">< رجوع إلى صفحة $2</a>',~~
	152	+ 'g-back-link' => '< رجوع إلى صفحة $2',
153	153	'g-choose-file' => 'اختر الملف:',
154	154	'g-cancel' => 'إلغاء',
155	155	'g-count' => '$1 يمتلك $2 {{PLURAL:$2\|هدية\|هدية}}.',
—	—	@@ -250,7 +250,7 @@
251	251	'g-add-message' => 'أضف رسالة',
252	252	'g-back-edit-gift' => 'رجوع لتعديل هذه الهدية',
253	253	'g-back-gift-list' => 'رجوع لقائمة الهدايا',
254		~~- 'g-back-link' => '<a href="$1">< رجوع إلى صفحة $2</a>',~~
	254	+ 'g-back-link' => '< رجوع إلى صفحة $2',
255	255	'g-choose-file' => 'اختر الملف:',
256	256	'g-cancel' => 'إلغاء',
257	257	'g-count' => '$1 يمتلك $2 {{PLURAL:$2\|هدية\|هدية}}.',
—	—	@@ -354,7 +354,7 @@
355	355	'g-add-message' => 'Дадаць паведамленьне',
356	356	'g-back-edit-gift' => 'Вярнуцца да рэдагаваньня гэтага падарунка',
357	357	'g-back-gift-list' => 'Вярнуцца да сьпісу падарункаў',
358		~~- 'g-back-link' => '<a href="$1">< Вярнуцца на старонку $2</a>',~~
	358	+ 'g-back-link' => '< Вярнуцца на старонку $2',
359	359	'g-choose-file' => 'Выбраць файл:',
360	360	'g-cancel' => 'Адмяніць',
361	361	'g-count' => '$1 мае $2 {{PLURAL:$2\|падарунак\|падарункі\|падарункаў}}.',
—	—	@@ -458,7 +458,7 @@
459	459	'g-add-message' => 'Füge eine Nachricht hinzu',
460	460	'g-back-edit-gift' => 'Zurück zur Geschenkbearbeitung',
461	461	'g-back-gift-list' => 'Zurück zur Geschenkeliste',
462		~~- 'g-back-link' => '<a href="$1">< Zurück zum Profil von $2</a>',~~
	462	+ 'g-back-link' => '< Zurück zum Profil von $2',
463	463	'g-choose-file' => 'Wähle Datei:',
464	464	'g-cancel' => 'Abbrechen',
465	465	'g-count' => '$1 hat $2 {{PLURAL:$2\|Geschenk\|Geschenke}}.',
—	—	@@ -608,7 +608,7 @@
609	609	'g-add-message' => 'Agregar un mensaje',
610	610	'g-back-edit-gift' => 'Regresar a editar este regalo',
611	611	'g-back-gift-list' => 'Regresar a lista de regalos',
612		~~- 'g-back-link' => '<a href="$1">< Regresar a la página de $2</a>',~~
	612	+ 'g-back-link' => '< Regresar a la página de $2',
613	613	'g-choose-file' => 'Escoger archivo:',
614	614	'g-cancel' => 'Cancelar',
615	615	'g-count' => '$1 tiene $2 {{PLURAL:$2\|regalo\|regalos}}.',
—	—	@@ -688,7 +688,7 @@
689	689	'g-add-message' => 'Lisää viesti',
690	690	'g-back-edit-gift' => 'Takaisin tämän lahjan muokkaamiseen',
691	691	'g-back-gift-list' => 'Takaisin lahjalistaan',
692		~~- 'g-back-link' => '<a href="$1">< Takaisin käyttäjän $2 sivulle</a>',~~
	692	+ 'g-back-link' => '< Takaisin käyttäjän $2 sivulle',
693	693	'g-choose-file' => 'Valitse tiedosto:',
694	694	'g-cancel' => 'Peruuta',
695	695	'g-count' => 'Käyttäjällä $1 on $2 {{PLURAL:$2\|lahja\|lahjaa}}.',
—	—	@@ -791,7 +791,7 @@
792	792	'g-add-message' => 'Ajouter un message',
793	793	'g-back-edit-gift' => 'Revenir à la modification de ce cadeau',
794	794	'g-back-gift-list' => 'Revenir à la liste des cadeaux',
795		~~- 'g-back-link' => '<a href="$1">< Revenir à la page de $2</a>',~~
	795	+ 'g-back-link' => '< Revenir à la page de $2',
796	796	'g-choose-file' => 'Choisir le fichier :',
797	797	'g-cancel' => 'Annuler',
798	798	'g-count' => '$1 a $2 {{PLURAL:$2\|cadeau\|cadeaux}}.',
—	—	@@ -893,7 +893,7 @@
894	894	'g-add-message' => 'Engadir unha mensaxe',
895	895	'g-back-edit-gift' => 'Voltar á edición deste agasallo',
896	896	'g-back-gift-list' => 'Voltar á lista de agasallos',
897		~~- 'g-back-link' => '<a href="$1">< Voltar á páxina de $2</a>',~~
	897	+ 'g-back-link' => '< Voltar á páxina de $2',
898	898	'g-choose-file' => 'Elixir o ficheiro:',
899	899	'g-cancel' => 'Cancelar',
900	900	'g-count' => '$1 ten {{PLURAL:$2\|un agasallo\|$2 agasallos}}.',
—	—	@@ -1002,7 +1002,7 @@
1003	1003	'g-add-message' => 'Fieg e Nochricht dezue',
1004	1004	'g-back-edit-gift' => 'Zrugg zum Bearbeite vu däm Gschänk',
1005	1005	'g-back-gift-list' => 'Zrugg zue dr Gschänklischt',
1006		~~- 'g-back-link' => '<a href="$1">< Zrugg zum Profil vu $2</a>',~~
	1006	+ 'g-back-link' => '< Zrugg zum Profil vu $2',
1007	1007	'g-choose-file' => 'Wehl Datei:',
1008	1008	'g-cancel' => 'Abbräche',
1009	1009	'g-count' => '$1 het $2 {{PLURAL:$2\|Gschänk\|Gschänk}}.',
—	—	@@ -1103,7 +1103,7 @@
1104	1104	'g-add-message' => 'Adder un message',
1105	1105	'g-back-edit-gift' => 'Retornar verso Modificar iste dono',
1106	1106	'g-back-gift-list' => 'Retornar al lista de donos',
1107		~~- 'g-back-link' => '<a href="$1">< Retornar al pagina de $2</a>',~~
	1107	+ 'g-back-link' => '< Retornar al pagina de $2',
1108	1108	'g-choose-file' => 'Selige file:',
1109	1109	'g-cancel' => 'Cancellar',
1110	1110	'g-count' => '$1 ha $2 {{PLURAL:$2\|dono\|donos}}.',
—	—	@@ -1212,7 +1212,7 @@
1213	1213	'g-add-message' => 'En Nohresch dobei donn',
1214	1214	'g-back-edit-gift' => 'Jangk retuur noh em Ändere för dat Jeschenk',
1215	1215	'g-back-gift-list' => 'Jangk retuur op de Leß met de Jeschenke',
1216		~~- 'g-back-link' => '<a href="$1">< Retuur noh dem $2 sing Sigg</a>',~~
	1216	+ 'g-back-link' => '< Retuur noh dem $2 sing Sigg',
1217	1217	'g-choose-file' => 'Donn de Datei ußwähle:',
1218	1218	'g-cancel' => 'Stopp! Avbreche!',
1219	1219	'g-count' => '{{GENDER:$1\|Dä\|Dat\|Dä Metmaacher}} $1 hät {{PLURAL:$2\|ei Jeschengk\|$2 Geschengke\|kei Jeschengk}}.',
—	—	@@ -1308,7 +1308,7 @@
1309	1309	'giftmanager-public' => 'ëffentlech',
1310	1310	'giftmanager-private' => 'privat',
1311	1311	'g-add-message' => 'Eng Noriicht derbäisetzen',
1312		~~- 'g-back-link' => '<a href="$1">< Zréck op dem $2 seng Säit</a>',~~
	1312	+ 'g-back-link' => '< Zréck op dem $2 seng Säit',
1313	1313	'g-choose-file' => 'Fichier wielen:',
1314	1314	'g-cancel' => 'Ofbriechen',
1315	1315	'g-current-image' => 'Aktuellt Bild',
—	—	@@ -1358,7 +1358,7 @@
1359	1359	'g-add-message' => 'Een bericht toevoegen',
1360	1360	'g-back-edit-gift' => 'Terug naar gift bewerken',
1361	1361	'g-back-gift-list' => 'Terug naar giftenlijst',
1362		~~- 'g-back-link' => '<a href="$1">< Terug naar de pagina van $2</a>',~~
	1362	+ 'g-back-link' => '< Terug naar de pagina van $2',
1363	1363	'g-choose-file' => 'Bestand kiezen:',
1364	1364	'g-cancel' => 'Annuleren',
1365	1365	'g-count' => '$1 heeft $2 {{PLURAL:$2\|gift\|giften}}.',
—	—	@@ -1459,7 +1459,7 @@
1460	1460	'g-add-message' => 'Legg til ei melding',
1461	1461	'g-back-edit-gift' => 'Attende til endring av gåva',
1462	1462	'g-back-gift-list' => 'Attende til gåvelista',
1463		~~- 'g-back-link' => '<a href="$1">< attende til sida til $2</a>',~~
	1463	+ 'g-back-link' => '< attende til sida til $2',
1464	1464	'g-choose-file' => 'Vel fil:',
1465	1465	'g-cancel' => 'Avrbyt',
1466	1466	'g-count' => '$1 har $2 {{PLURAL:$2\|éi gåva\|gåver}}.',
—	—	@@ -1561,7 +1561,7 @@
1562	1562	'g-add-message' => 'Apondre un messatge',
1563	1563	'g-back-edit-gift' => "Tornar a la modificacion d'aqueste present",
1564	1564	'g-back-gift-list' => 'Tornar a la lista dels presents',
1565		~~- 'g-back-link' => '<a href="$1">< Tornar a la pagina de $2</a>',~~
	1565	+ 'g-back-link' => '< Tornar a la pagina de $2',
1566	1566	'g-choose-file' => 'Causir lo fichièr :',
1567	1567	'g-cancel' => 'Anullar',
1568	1568	'g-count' => '$1 a $2 {{PLURAL:$2\|present\|presents}}.',
—	—	@@ -1663,7 +1663,7 @@
1664	1664	'g-add-message' => 'Dodaj wiadomość',
1665	1665	'g-back-edit-gift' => 'Powrót do edycji tego prezentu',
1666	1666	'g-back-gift-list' => 'Powrót do listy prezentów',
1667		~~- 'g-back-link' => '<a href="$1">< Powrót do strony $2</a>',~~
	1667	+ 'g-back-link' => '< Powrót do strony $2',
1668	1668	'g-choose-file' => 'Wybierz plik',
1669	1669	'g-cancel' => 'Anuluj',
1670	1670	'g-count' => '$1 otrzymał $2 {{PLURAL:$2\|prezent\|prezenty\|prezentów}}.',
—	—	@@ -1715,7 +1715,7 @@
1716	1716	'g-add-message' => 'Adicionar Mensagem',
1717	1717	'g-back-edit-gift' => 'Volar para Editar Este Presente',
1718	1718	'g-back-gift-list' => 'Voltar para Lista de Presentes',
1719		~~- 'g-back-link' => '<a href="$1">< Voltar para página de $2</a>',~~
	1719	+ 'g-back-link' => '< Voltar para página de $2',
1720	1720	'g-choose-file' => 'Escolher Arquivo:',
1721	1721	'g-cancel' => 'Cancelar',
1722	1722	'g-count' => '$1 tem $2 {{PLURAL:$2\|presente\|presentes}}.',
—	—	@@ -1817,7 +1817,7 @@
1818	1818	'g-add-message' => 'Pridať správu',
1819	1819	'g-back-edit-gift' => 'Späť na Upraviť tento darček',
1820	1820	'g-back-gift-list' => 'Späť na Zoznam darčekov',
1821		~~- 'g-back-link' => '<a href="$1">< Späť na stránku $2</a>',~~
	1821	+ 'g-back-link' => '< Späť na stránku $2',
1822	1822	'g-choose-file' => 'Vybrať súbor:',
1823	1823	'g-cancel' => 'Zrušiť',
1824	1824	'g-count' => '$1 má $2 {{PLURAL:$2\|darček\|darčeky\|darčekov}}.',
—	—	@@ -1929,7 +1929,7 @@
1930	1930	'g-add-message' => 'Magdagdag ng isang Mensahe',
1931	1931	'g-back-edit-gift' => 'Bumalik sa Baguhin ang Handog na Ito',
1932	1932	'g-back-gift-list' => 'Bumalik sa Talaan ng Handog',
1933		~~- 'g-back-link' => '<a href="$1">< Bumalik sa Pahina ni $2</a>',~~
	1933	+ 'g-back-link' => '< Bumalik sa Pahina ni $2',
1934	1934	'g-choose-file' => 'Piliin ang Talaksan:',
1935	1935	'g-cancel' => 'Huwag ituloy',
1936	1936	'g-count' => 'Si $1 ay may $2 {{PLURAL:$2\|handog\|mga handog}}.',
Index: trunk/extensions/SocialProfile/UserGifts/SpecialGiveGift.php
—	—	@@ -95,7 +95,7 @@
96	96	$output .= $wgOut->setPageTitle( wfMsg('g-sent-title', $this->user_name_to) );
97	97
98	98	$output .= "<div class=\"back-links\">
99		~~- ".wfMsg('g-back-link', $user_title->escapeFullURL(), $this->user_name_to)."~~
	99	+ <a href=\"" . $user_title->escapeFullURL() . "\">" . wfMsg( 'g-back-link', $this->user_name_to ) . "</a>
100	100	</div>
101	101	<div class=\"g-message\">
102	102	".wfMsg('g-sent-message', $this->user_name_to)."
—	—	@@ -234,7 +234,7 @@
235	235	$wgOut->setPagetitle( wfMsg('g-give-all-title', $this->user_name_to) );
236	236
237	237	$output .= '<div class="back-links">
238		~~- '.wfMsg('g-back-link', $user->escapeFullURL(), $this->user_name_to).'~~
	238	+ <a href="' . $user->escapeFullURL() . '">' . wfMsg( 'g-back-link', $this->user_name_to ) . '</a>
239	239	</div>
240	240	<div class="g-message">
241	241	'.wfMsg('g-give-all', $this->user_name_to).'
Index: trunk/extensions/SocialProfile/UserGifts/SpecialViewGift.php
—	—	@@ -55,7 +55,7 @@
56	56	$output .= $wgOut->setPageTitle( wfMsg( 'g-description-title', $gift['user_name_to'], $gift['name'] ) );
57	57
58	58	$output .= '<div class="back-links">
59		~~- '.wfMsg('g-back-link', Title::makeTitle( NS_USER, $gift['user_name_to'] )->escapeFullURL(), $gift['user_name_to']).'~~
	59	+ <a href="' . Title::makeTitle( NS_USER, $gift['user_name_to'] )->escapeFullURL() . '">' . wfMsg( 'g-back-link', $gift['user_name_to'] ) . '</a>
60	60	</div>';
61	61
62	62	$user = Title::makeTitle( NS_USER, $gift['user_name_from'] );
Index: trunk/extensions/SocialProfile/UserGifts/SpecialRemoveGift.php
—	—	@@ -51,7 +51,7 @@
52	52	$out .= $wgOut->setPageTitle( wfMsg( 'g-remove-success-title', $gift['name'] ) );
53	53
54	54	$out .= "<div class=\"back-links\">
55		~~- ".wfMsg( 'g-back-link', $wgUser->getUserPage()->escapeFullURL(), $gift['user_name_to'] )."~~
	55	+ <a href=\"" . $wgUser->getUserPage()->escapeFullURL() . "\">" . wfMsg( 'g-back-link', $gift['user_name_to'] ) . "</a>
56	56	</div>
57	57	<div class=\"g-container\">
58	58	{$gift_image}
—	—	@@ -82,7 +82,7 @@
83	83	$output = '';
84	84	$output .= $wgOut->setPagetitle( wfMsg( 'g-remove-title', $gift['name'] ) );
85	85	$output .= "<div class=\"back-links\">
86		~~- ".wfMsg( 'g-back-link', $wgUser->getUserPage()->escapeFullURL(), $gift['user_name_to'] )."~~
	86	+ <a href=\"" . $wgUser->getUserPage()->escapeFullURL() . "\">" . wfMsg( 'g-back-link', $gift['user_name_to'] ) . "</a>
87	87	</div>
88	88	<form action=\"\" method=\"post\" enctype=\"multipart/form-data\" name=\"form1\">
89	89	<div class=\"g-remove-message\">
Index: trunk/extensions/SocialProfile/UserGifts/SpecialViewGifts.php
—	—	@@ -73,8 +73,8 @@
74	74	*/
75	75	$output .= $wgOut->setPageTitle( wfMsg('g-list-title', $rel->user_name) );
76	76
77		~~- $output .= '<div class="back-links">~~
78		~~- '.wfMsg( 'g-back-link', $user->getFullURL(), $rel->user_name ).'~~
	77	+ $output .= '<div class="back-links"><a href="' . $user->getFullURL() . '">
	78	+ ' . wfMsg( 'g-back-link', $rel->user_name ) . '</a>
79	79	</div>
80	80	<div class="g-count">
81	81	'.wfMsgExt( 'g-count', 'parsemag', $rel->user_name, $total ).'

Follow-up revisions

Revision	Commit summary	Author	Date
r47689	SocialProfile: please read the fine source (follow-up to r47449)	ashley	23:02, 22 February 2009

Status & tagging log

19:06, 18 February 2009 Brion VIBBER (talk | contribs) changed the status of r47449 [removed: new added: deferred]