r47138 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r47137‎ | r47138 | r47139 >
Date:11:56, 11 February 2009
Author:purodha
Status:ok (Comments)
Tags:
Comment:
Bugfis, making ?uselang=qqq an invalid language code, see
https://bugzilla.wikimedia.org/show_bug.cgi?id=17445
Modified paths:
  • /trunk/phase3/includes/StubObject.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/StubObject.php
——@@ -154,7 +154,7 @@
155155 }
156156
157157 # Validate $code
158 - if( empty( $code ) || !preg_match( '/^[a-z-]+$/', $code ) ) {
 158+ if( empty( $code ) || !preg_match( '/^[a-z-]+$/', $code ) || ( $code === 'qqq' ) ) {
159159 wfDebug( "Invalid user language code\n" );
160160 $code = $wgContLanguageCode;
161161 }

Comments

#Comment by Siebrand (talk | contribs)   12:07, 11 February 2009

Please update RELEASE-NOTES when fixing a bugzilla in core. Also please observe the formatting of commit comment for commits fixing bugzilla related issue.

(bug #####) Description [more info]

#Comment by Purodha (talk | contribs)   09:15, 1 April 2009

RELEASE-NOTES updated with r47657

Status & tagging log