r47083 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47082‎ | r47083 | r47084 >
Date:13:04, 10 February 2009
Author:ialex
Status:deferred (Comments)
Tags:
Comment:
Allow entities so that the " " in pipe-separator are not escaped twice
Modified paths:
  • /trunk/phase3/includes/LogEventsList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogEventsList.php
@@ -41,7 +41,7 @@
4242 $messages = array( 'revertmerge', 'protect_change', 'unblocklink', 'change-blocklink',
4343 'revertmove', 'undeletelink', 'revdel-restore', 'rev-delundel', 'hist', 'pipe-separator' );
4444 foreach( $messages as $msg ) {
45 - $this->message[$msg] = wfMsgExt( $msg, array( 'escape' ) );
 45+ $this->message[$msg] = wfMsgExt( $msg, array( 'escapenoentities' ) );
4646 }
4747 }
4848 }
@@ -93,7 +93,7 @@
9494 }
9595
9696 private function getFilterLinks( $logType, $filter ) {
97 - global $wgTitle, $wgLang;
 97+ global $wgTitle;
9898 // show/hide links
9999 $messages = array( wfMsgHtml( 'show' ), wfMsgHtml( 'hide' ) );
100100 // Option value -> message mapping
@@ -106,7 +106,7 @@
107107 $links[$type] = wfMsgHtml( "log-show-hide-{$type}", $link );
108108 }
109109 // Build links
110 - return $wgLang->pipeList( $links );
 110+ return implode( ' | ', $links );
111111 }
112112
113113 private function getDefaultQuery() {

Comments

#Comment by Siebrand (talk | contribs)   13:08, 10 February 2009

@@ -93,7 +93,7 @@

and

@@ -106,7 +106,7 @@

have been committed accidentally, it seems.

#Comment by IAlex (talk | contribs)   13:11, 10 February 2009

fixed in r47084.

Status & tagging log