r47014 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r47013‎ | r47014 | r47015 >
Date:15:55, 8 February 2009
Author:siebrand
Status:deferred
Tags:
Comment:
* Recommit r39503. (bug 14468) Lines in classic RecentChanges and Watchlist now have classes "mw-line-odd" and "mw-line-even" to make styling using css possible. Implemented in OldChangesList::recentChangesLine using an additional parameter, while keeping behaviour for other uses unchanged. Did not see any use adding this to ChangesList::recentChangesLine.
* keep RELEASE-NOTES lines under 80 characters
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/ChangesList.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialRecentchanges.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialWatchlist.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangesList.php
@@ -361,7 +361,7 @@
362362 /**
363363 * Format a line using the old system (aka without any javascript).
364364 */
365 - public function recentChangesLine( &$rc, $watched = false ) {
 365+ public function recentChangesLine( &$rc, $watched = false, $linenumber = NULL ) {
366366 global $wgContLang, $wgLang, $wgRCShowChangedSize, $wgUser;
367367 wfProfileIn( __METHOD__ );
368368 # Should patrol-related stuff be shown?
@@ -372,6 +372,16 @@
373373
374374 $s = '';
375375 $classes = array();
 376+ // use mw-line-even/mw-line-odd class only if linenumber is given (feature from bug 14468)
 377+ if( $linenumber ) {
 378+ if( $linenumber & 1 ) {
 379+ $classes[] = 'mw-line-odd';
 380+ }
 381+ else {
 382+ $classes[] = 'mw-line-even';
 383+ }
 384+ }
 385+
376386 // Moved pages
377387 if( $rc->mAttribs['rc_type'] == RC_MOVE || $rc->mAttribs['rc_type'] == RC_MOVE_OVER_REDIRECT ) {
378388 $this->insertMove( $s, $rc );
Index: trunk/phase3/includes/specials/SpecialRecentchanges.php
@@ -381,7 +381,7 @@
382382 }
383383 $rc->numberofWatchingusers = $watcherCache[$obj->rc_namespace][$obj->rc_title];
384384 }
385 - $s .= $list->recentChangesLine( $rc, !empty( $obj->wl_user ) );
 385+ $s .= $list->recentChangesLine( $rc, !empty( $obj->wl_user ), $counter );
386386 --$limit;
387387 }
388388 $s .= $list->endRecentChangesList();
Index: trunk/phase3/includes/specials/SpecialWatchlist.php
@@ -357,7 +357,7 @@
358358 $rc->numberofWatchingusers = 0;
359359 }
360360
361 - $s .= $list->recentChangesLine( $rc, $updated );
 361+ $s .= $list->recentChangesLine( $rc, $updated, $counter );
362362 }
363363 $s .= $list->endRecentChangesList();
364364
Index: trunk/phase3/RELEASE-NOTES
@@ -74,9 +74,10 @@
7575 * Local redirects to foreign images are now displayed on the ImagePage when
7676 viewing on the local wiki.
7777 * (bug 8249) The magic words for namespaces and pagenames can now be used as
78 - parser functions to return the desired namespace or normalized title/title part
79 - for a given title.
80 -* Styled #mw-data-after-content in cologneblue.css to match the rest of the font (bug 17110)
 78+ parser functions to return the desired namespace or normalized title/title
 79+ part for a given title.
 80+* (bug 17110) Styled #mw-data-after-content in cologneblue.css to match the
 81+ rest of the font
8182 * (bug 7556) Time zone names in signatures lack i18n
8283 * (bug 3311) Automatic category redirects
8384 * (bug 17236) Suppress 'watch user page link' for IP range blocks
@@ -88,6 +89,8 @@
8990 LanguageConverter class)
9091 * (bug 17379) Contributions-title is now parsed for magic words.
9192 * Preprocessor output now cached in memcached.
 93+* (bug 14468) Lines in classic RecentChanges and Watchlist have classes
 94+ "mw-line-odd" and "mw-line-even" to make styling using css possible.
9295
9396 === Bug fixes in 1.15 ===
9497 * (bug 16968) Special:Upload no longer throws useless warnings.
@@ -120,21 +123,23 @@
121124 * (bug 15811) Re-upload form tweaks: license fields removed, destination locked,
122125 comment label uses better message
123126 * Whole HTML validation ($wgValidateAllHtml) now works with external tidy
124 -* Parser tests no longer fail when $wgExternalLinkTarget is set in LocalSettings
125 -* (bug 15391) catch DBQueryErrors on external storage insertion. This avoids error
126 - messages on save were the edit in fact is saved.
 127+* Parser tests no longer fail when $wgExternalLinkTarget is set in
 128+ LocalSettings
 129+* (bug 15391) catch DBQueryErrors on external storage insertion. This avoids
 130+ error messages on save were the edit in fact is saved.
127131 * (bug 17184) Remove duplicate "z" accesskey in MonoBook
128132 * Parser tests no longer fail when $wgAlwaysUseTidy is set in LocalSettings.php
129133 * Removed redundant dupe warnings on reupload for the same title. Dupe warnings
130134 for identical files at different titles are still given.
131135 * Add 'change tagging' facility, where changes can be tagged internally with
132 - certain designations, which are displayed on various summaries of changes, and
133 - the entries can be styled with CSS.
 136+ certain designations, which are displayed on various summaries of changes,
 137+ and the entries can be styled with CSS.
134138 * (bug 17207) Fix regression breaking category page display on PHP 5.1
135139 * Categoryfinder utility class no longer fails on invalid input or gives wrong
136140 results for category names that include pseudo-namespaces
137141 * (bug 17252) Galician numbering format
138 -* (bug 17146) Fix for UTF-8 and short word search for some possible MySQL configs
 142+* (bug 17146) Fix for UTF-8 and short word search for some possible MySQL
 143+ configs
139144 * (bug 7480) Internationalize database error message
140145 * (bug 16555) Number of links to mediawiki.org scaled back on post-installation
141146 * (bug 14938) Removing a section no longer leaves excess whitespace
@@ -174,8 +179,8 @@
175180 performance concerns
176181 * Listing (semi-)deleted revisions and log entries as well in prop=revisions and
177182 list=logevents
178 -* (bug 11430) BREAKING CHANGE: Modules may return fewer results than the limit and still
179 - set a query-continue in some cases
 183+* (bug 11430) BREAKING CHANGE: Modules may return fewer results than the limit
 184+ and still set a query-continue in some cases
180185
181186 === Languages updated in 1.15 ===
182187

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r39503(bug 14468) Lines in classic RecentChanges and Watchlist now have classes "od...siebrand21:16, 16 August 2008
r39622Revert r39503, 39507 "(bug 14468) Lines in classic RecentChanges and Watchlis...brion00:15, 19 August 2008

Status & tagging log