r39622 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r39621‎ | r39622 | r39623 >
Date:00:15, 19 August 2008
Author:brion
Status:old
Tags:
Comment:
Revert r39503, 39507 "(bug 14468) Lines in classic RecentChanges and Watchlist now have classes "odd" and "even" to make colouring using css possible."

These alternating background colors are imho not very attractive, and make the display busy and confusing, rather than easier to read.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/ChangesList.php (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialRecentchanges.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialWatchlist.php (modified) (history)
  • /trunk/phase3/skins/common/shared.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/common/shared.css
@@ -247,8 +247,3 @@
248248 #shared-image-dup, #shared-image-conflict {
249249 font-style: italic;
250250 }
251 -
252 -/* Alternating background colours on Watchlist and RecentChanges */
253 -li.odd {
254 - background-color: #e8e8e8
255 -}
Index: trunk/phase3/includes/ChangesList.php
@@ -306,7 +306,7 @@
307307 /**
308308 * Format a line using the old system (aka without any javascript).
309309 */
310 - public function recentChangesLine( &$rc, $watched = false, $linenumber = NULL ) {
 310+ public function recentChangesLine( &$rc, $watched = false ) {
311311 global $wgContLang, $wgRCShowChangedSize, $wgUser;
312312
313313 $fname = 'ChangesList::recentChangesLineOld';
@@ -321,17 +321,7 @@
322322
323323 $this->insertDateHeader($s,$rc_timestamp);
324324
325 - // use even/odd class only if linenumber is given (feature from bug 14468)
326 - if( $linenumber ) {
327 - if( $linenumber & 1 ) {
328 - $s .= '<li class="odd">';
329 - }
330 - else {
331 - $s .= '<li class="even">';
332 - }
333 - } else {
334 - $s .= '<li>';
335 - }
 325+ $s .= '<li>';
336326
337327 // Moved pages
338328 if( $rc_type == RC_MOVE || $rc_type == RC_MOVE_OVER_REDIRECT ) {
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1382,7 +1382,7 @@
13831383 * to ensure that client-side caches don't keep obsolete copies of global
13841384 * styles.
13851385 */
1386 -$wgStyleVersion = '166';
 1386+$wgStyleVersion = '165';
13871387
13881388
13891389 # Server-side caching:
Index: trunk/phase3/includes/specials/SpecialRecentchanges.php
@@ -378,7 +378,7 @@
379379 }
380380 $rc->numberofWatchingusers = $watcherCache[$obj->rc_namespace][$obj->rc_title];
381381 }
382 - $s .= $list->recentChangesLine( $rc, !empty( $obj->wl_user ), $counter );
 382+ $s .= $list->recentChangesLine( $rc, !empty( $obj->wl_user ) );
383383 --$limit;
384384 }
385385 }
Index: trunk/phase3/includes/specials/SpecialWatchlist.php
@@ -342,7 +342,7 @@
343343 $rc->numberofWatchingusers = 0;
344344 }
345345
346 - $s .= $list->recentChangesLine( $rc, $updated, $counter );
 346+ $s .= $list->recentChangesLine( $rc, $updated );
347347 }
348348 $s .= $list->endRecentChangesList();
349349
Index: trunk/phase3/RELEASE-NOTES
@@ -88,8 +88,6 @@
8989 Show/Hide logged in users, Show/Hide anonymous, Invert namespace selection
9090 * Added hook 'UserrightsChangeableGroups' to allow modification of what
9191 groups may be added or removed via the Special:UserRights interface.
92 -* (bug 14468) Lines in classic RecentChanges and Watchlist have alternating
93 - background colours based on classes "odd" and "even".
9492 * (bug 14187) In Special:Userlogin the buttons "Log in" and "E-mail new
9593 password" now have classes "mw-loginbutton" and "mw-mailmypasswordbutton".
9694 * HTML entities like &nbsp; now work (are not escaped) in edit summaries.

Follow-up revisions

RevisionCommit summaryAuthorDate
r47014* Recommit r39503. (bug 14468) Lines in classic RecentChanges and Watchlist n...siebrand15:55, 8 February 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r39503(bug 14468) Lines in classic RecentChanges and Watchlist now have classes "od...siebrand21:16, 16 August 2008

Status & tagging log