r46895 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46894‎ | r46895 | r46896 >
Date:05:31, 6 February 2009
Author:aaron
Status:deferred
Tags:
Comment:
Rename constant alias to be more intuitive
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.class.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/FlaggedRevsXML.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/specialpages/Stabilization_body.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/specialpages/StablePages_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -29,8 +29,8 @@
3030 }
3131
3232 # Quality -> Sighted (default)
33 -if( !defined('FLAGGED_VIS_NORMAL') )
34 - define('FLAGGED_VIS_NORMAL',0);
 33+if( !defined('FLAGGED_VIS_QUALITY') )
 34+ define('FLAGGED_VIS_QUALITY',0);
3535 # No precedence
3636 if( !defined('FLAGGED_VIS_LATEST') )
3737 define('FLAGGED_VIS_LATEST',1);
Index: trunk/extensions/FlaggedRevs/FlaggedRevs.class.php
@@ -277,7 +277,7 @@
278278 $select = FLAGGED_VIS_PRISTINE;
279279 break;
280280 case 1:
281 - $select = FLAGGED_VIS_NORMAL;
 281+ $select = FLAGGED_VIS_QUALITY;
282282 break;
283283 default:
284284 $select = FLAGGED_VIS_LATEST;
Index: trunk/extensions/FlaggedRevs/specialpages/Stabilization_body.php
@@ -77,7 +77,7 @@
7878 // Custom reason takes precedence
7979 $this->reason = strlen($this->reason) ? $this->reason : $this->reasonSelection;
8080 // Validate precedence setting
81 - $allowed = array(FLAGGED_VIS_NORMAL,FLAGGED_VIS_LATEST,FLAGGED_VIS_PRISTINE);
 81+ $allowed = array(FLAGGED_VIS_QUALITY,FLAGGED_VIS_LATEST,FLAGGED_VIS_PRISTINE);
8282 if( $this->select && !in_array( $this->select, $allowed ) ) {
8383 $isValid = false;
8484 }
@@ -170,8 +170,8 @@
171171 Xml::fieldset( wfMsg( 'stabilization-select' ), false ) .
172172 Xml::radioLabel( wfMsg( 'stabilization-select3' ), 'wpStableconfig-select', FLAGGED_VIS_PRISTINE,
173173 'stable-select3', FLAGGED_VIS_PRISTINE == $this->select, $this->disabledAttrib ) . '<br />' . "\n" .
174 - Xml::radioLabel( wfMsg( 'stabilization-select1' ), 'wpStableconfig-select', FLAGGED_VIS_NORMAL,
175 - 'stable-select1', FLAGGED_VIS_NORMAL == $this->select, $this->disabledAttrib ) . '<br />' . "\n" .
 174+ Xml::radioLabel( wfMsg( 'stabilization-select1' ), 'wpStableconfig-select', FLAGGED_VIS_QUALITY,
 175+ 'stable-select1', FLAGGED_VIS_QUALITY == $this->select, $this->disabledAttrib ) . '<br />' . "\n" .
176176 Xml::radioLabel( wfMsg( 'stabilization-select2' ), 'wpStableconfig-select', FLAGGED_VIS_LATEST,
177177 'stable-select2', FLAGGED_VIS_LATEST == $this->select, $this->disabledAttrib ) . '<br />' . "\n" .
178178 Xml::closeElement( 'fieldset' ) .
Index: trunk/extensions/FlaggedRevs/specialpages/StablePages_body.php
@@ -68,7 +68,7 @@
6969
7070 if( intval($row->fpc_select) === FLAGGED_VIS_PRISTINE ) {
7171 $type = wfMsgHtml('stablepages-prec-pristine');
72 - } else if( intval($row->fpc_select) === FLAGGED_VIS_NORMAL ) {
 72+ } else if( intval($row->fpc_select) === FLAGGED_VIS_QUALITY ) {
7373 $type = wfMsgHtml('stablepages-prec-quality');
7474 } else {
7575 $type = wfMsgHtml('stablepages-prec-none');
Index: trunk/extensions/FlaggedRevs/FlaggedRevsXML.php
@@ -63,7 +63,7 @@
6464 $s = Xml::openElement( 'select', array('name' => 'precedence','id' => 'wpPrecedence') );
6565 $s .= Xml::option( wfMsg( "revreview-filter-level-0" ), FLAGGED_VIS_LATEST, $selected==FLAGGED_VIS_LATEST );
6666 if( FlaggedRevs::qualityVersions() )
67 - $s .= Xml::option( wfMsg( "revreview-filter-level-1" ), FLAGGED_VIS_NORMAL, $selected==FLAGGED_VIS_NORMAL );
 67+ $s .= Xml::option( wfMsg( "revreview-filter-level-1" ), FLAGGED_VIS_QUALITY, $selected==FLAGGED_VIS_QUALITY );
6868 if( FlaggedRevs::pristineVersions() )
6969 $s .= Xml::option( wfMsg( "revreview-filter-level-2" ), FLAGGED_VIS_PRISTINE, $selected==FLAGGED_VIS_PRISTINE );
7070 $s .= Xml::closeElement('select')."\n";

Status & tagging log