r46894 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46893‎ | r46894 | r46895 >
Date:05:27, 6 February 2009
Author:aaron
Status:deferred
Tags:
Comment:
Fix label
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevsXML.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/specialpages/StablePages_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/specialpages/StablePages_body.php
@@ -32,7 +32,7 @@
3333 $form = Xml::openElement( 'form', array( 'name' => 'stablepages', 'action' => $wgScript, 'method' => 'get' ) );
3434 $form .= "<fieldset><legend>".wfMsg('stablepages')."</legend>\n";
3535 $form .= FlaggedRevsXML::getNamespaceMenu( $this->namespace ) . '&nbsp;';
36 - $form .= Xml::label( wfMsg('stablepages-precedence'), 'precedence', 'precedence' ) . '&nbsp;';
 36+ $form .= Xml::label( wfMsg('stablepages-precedence'), 'wpPrecedence' ) . '&nbsp;';
3737 $form .= FlaggedRevsXML::getPrecedenceMenu( $this->precedence ) . '&nbsp;';
3838 $form .= " ".Xml::submitButton( wfMsg( 'go' ) );
3939 $form .= Xml::hidden( 'title', $wgTitle->getPrefixedDBKey() );
Index: trunk/extensions/FlaggedRevs/FlaggedRevsXML.php
@@ -47,7 +47,7 @@
4848 */
4949 public static function getLevelMenu( $selected=null ) {
5050 wfLoadExtensionMessages( 'FlaggedRevs' );
51 - $s = Xml::openElement( 'select', array('name' => 'level') );
 51+ $s = Xml::openElement( 'select', array('name' => 'level','id' => 'wpLevel') );
5252 $s .= Xml::option( wfMsg( "revreview-filter-level-0" ), 0, $selected===0 );
5353 if( FlaggedRevs::qualityVersions() )
5454 $s .= Xml::option( wfMsg( "revreview-filter-level-1" ), 1, $selected===1 );
@@ -60,7 +60,7 @@
6161
6262 public static function getPrecedenceMenu( $selected=null ) {
6363 wfLoadExtensionMessages( 'FlaggedRevs' );
64 - $s = Xml::openElement( 'select', array('name' => 'precedence') );
 64+ $s = Xml::openElement( 'select', array('name' => 'precedence','id' => 'wpPrecedence') );
6565 $s .= Xml::option( wfMsg( "revreview-filter-level-0" ), FLAGGED_VIS_LATEST, $selected==FLAGGED_VIS_LATEST );
6666 if( FlaggedRevs::qualityVersions() )
6767 $s .= Xml::option( wfMsg( "revreview-filter-level-1" ), FLAGGED_VIS_NORMAL, $selected==FLAGGED_VIS_NORMAL );

Status & tagging log