r46849 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46848‎ | r46849 | r46850 >
Date:15:46, 5 February 2009
Author:catrope
Status:deferred
Tags:
Comment:
Fix regression from r46845 which broke ApiResult::cleanUpUTF8() and caused an E_NOTICE
Modified paths:
  • /trunk/phase3/includes/api/ApiResult.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiResult.php
@@ -275,8 +275,7 @@
276276 */
277277 public function cleanUpUTF8()
278278 {
279 - $data = & $this->getData();
280 - array_walk_recursive($data, array('ApiResult', 'cleanUp_helper'));
 279+ array_walk_recursive($this->mData, array('ApiResult', 'cleanUp_helper'));
281280 }
282281
283282 private static function cleanUp_helper($s)

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r46845* API: BREAKING CHANGE: (bug 11430) Return fewer results than the limit in so...catrope14:30, 5 February 2009

Status & tagging log