r46823 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46822‎ | r46823 | r46824 >
Date:22:51, 4 February 2009
Author:catrope
Status:ok (Comments)
Tags:
Comment:
API: BREAKING CHANGE: Remove rctitles parameter from list=recentchanges for performance reasons (requests using it time out on enwiki)
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryRecentChanges.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryRecentChanges.php
@@ -97,25 +97,6 @@
9898 $this->addWhereRange('rc_timestamp', $params['dir'], $params['start'], $params['end']);
9999 $this->addWhereFld('rc_namespace', $params['namespace']);
100100 $this->addWhereFld('rc_deleted', 0);
101 - if($params['titles'])
102 - {
103 - $lb = new LinkBatch;
104 - foreach($params['titles'] as $t)
105 - {
106 - $obj = Title::newFromText($t);
107 - $lb->addObj($obj);
108 - if($obj->getNamespace() < 0)
109 - {
110 - // LinkBatch refuses these, but we need them anyway
111 - if(!array_key_exists($obj->getNamespace(), $lb->data))
112 - $lb->data[$obj->getNamespace()] = array();
113 - $lb->data[$obj->getNamespace()][$obj->getDBKey()] = 1;
114 - }
115 - }
116 - $where = $lb->constructSet('rc', $this->getDB());
117 - if($where != '')
118 - $this->addWhere($where);
119 - }
120101
121102 if(!is_null($params['type']))
122103 $this->addWhereFld('rc_type', $this->parseRCType($params['type']));
@@ -389,9 +370,6 @@
390371 ApiBase :: PARAM_ISMULTI => true,
391372 ApiBase :: PARAM_TYPE => 'namespace'
392373 ),
393 - 'titles' => array(
394 - ApiBase :: PARAM_ISMULTI => true
395 - ),
396374 'prop' => array (
397375 ApiBase :: PARAM_ISMULTI => true,
398376 ApiBase :: PARAM_DFLT => 'title|timestamp|ids',
@@ -451,7 +429,6 @@
452430 'end' => 'The timestamp to end enumerating.',
453431 'dir' => 'In which direction to enumerate.',
454432 'namespace' => 'Filter log entries to only this namespace(s)',
455 - 'titles' => 'Filter log entries to only these page titles',
456433 'prop' => 'Include additional pieces of information',
457434 'token' => 'Which tokens to obtain for each change',
458435 'show' => array (

Follow-up revisions

RevisionCommit summaryAuthorDate
r46824Commit RELEASE-NOTES for r46823catrope22:56, 4 February 2009

Comments

#Comment by Catrope (talk | contribs)   22:56, 4 February 2009

RELEASE-NOTES updated in r46824

Status & tagging log