r46762 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46761‎ | r46762 | r46763 >
Date:13:56, 3 February 2009
Author:soxred93
Status:deferred (Comments)
Tags:
Comment:
When creating a new section, one can specify the 'nosummary' parameter to disallow creation of a section title
Modified paths:
  • /trunk/phase3/includes/EditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/EditPage.php
@@ -1340,7 +1340,7 @@
13411341 $autosumm = $this->autoSumm ? $this->autoSumm : md5( $this->summary );
13421342 $summaryhiddens .= Xml::hidden( 'wpAutoSummary', $autosumm );
13431343 if ( $this->section == 'new' ) {
1344 - $commentsubject="<span id='wpSummaryLabel'><label for='wpSummary'>{$subject}</label></span>\n<input tabindex='1' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' />{$summaryhiddens}<br />";
 1344+ $commentsubject = $wgRequest->getBool( 'nosummary' ) ? '' : "<span id='wpSummaryLabel'><label for='wpSummary'>{$subject}</label></span>\n<input tabindex='1' type='text' value=\"$summarytext\" name='wpSummary' id='wpSummary' maxlength='200' size='60' />{$summaryhiddens}<br />";
13451345 $editsummary = "<div class='editOptions'>\n";
13461346 global $wgParser;
13471347 $formattedSummary = wfMsgForContent( 'newsectionsummary', $wgParser->stripSectionName( $this->summary ) );

Comments

#Comment by Werdna (talk | contribs)   23:13, 12 February 2009

That line seriously needs breaking. At 1680x1050, it's two screens worth.

#Comment by Werdna (talk | contribs)   23:43, 12 February 2009

That and some other ugly code fixed in r47202.

Status & tagging log