r46685 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46684‎ | r46685 | r46686 >
Date:19:01, 1 February 2009
Author:nikerabbit
Status:deferred (Comments)
Tags:
Comment:
* Small cleanups
Modified paths:
  • /trunk/phase3/maintenance/changePassword.php (modified) (history)
  • /trunk/phase3/maintenance/language/dumpMessages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/changePassword.php
@@ -13,7 +13,7 @@
1414 $optionsWithArgs = array( 'user', 'password' );
1515 require_once 'commandLine.inc';
1616
17 -$USAGE =
 17+$USAGE =
1818 "Usage: php changePassword.php [--user=user --password=password | --help]\n" .
1919 "\toptions:\n" .
2020 "\t\t--help show this message\n" .
@@ -50,8 +50,6 @@
5151 }
5252
5353 function main() {
54 - $fname = 'ChangePassword::main';
55 -
5654 $this->user->setPassword( $this->password );
5755 $this->user->saveSettings();
5856 }
Index: trunk/phase3/maintenance/language/dumpMessages.php
@@ -7,11 +7,9 @@
88
99 /** */
1010 require_once( dirname(__FILE__).'/../commandLine.inc' );
11 -$wgMessageCache->disableTransform();
1211 $messages = array();
1312 $wgEnglishMessages = array_keys( Language::getMessagesFor( 'en' ) );
14 -foreach ( $wgEnglishMessages as $key )
15 -{
 13+foreach ( $wgEnglishMessages as $key ) {
1614 $messages[$key] = wfMsg( $key );
1715 }
1816 print "MediaWiki $wgVersion language file\n";

Comments

#Comment by Werdna (talk | contribs)   18:38, 12 February 2009
-$wgMessageCache->disableTransform();

Why not wfMsgNoTrans() instead?

#Comment by Nikerabbit (talk | contribs)   20:27, 12 February 2009

Or just remove the whole script if nobody uses it enough to have been noticed this during the years?

Status & tagging log