r46549 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46548‎ | r46549 | r46550 >
Date:20:54, 29 January 2009
Author:raymond
Status:deferred (Comments)
Tags:
Comment:
* Move class=error from message to program code. Other languages will be handled by Translatewiki
* Wrap message 'confirmemail_pending' into a div with CSS classes "error" and "mw-confirmemail-pending"
* Fix double escaping of submit button
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialConfirmemail.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialConfirmemail.php
@@ -68,13 +68,13 @@
6969 $wgOut->addWikiMsg( 'emailauthenticated', $time, $d, $t );
7070 }
7171 if( $wgUser->isEmailConfirmationPending() ) {
72 - $wgOut->addWikiMsg( 'confirmemail_pending' );
 72+ $wgOut->wrapWikiMsg( "<div class=\"error mw-confirmemail-pending\">$1</div>", 'confirmemail_pending' );
7373 }
7474 $wgOut->addWikiMsg( 'confirmemail_text' );
7575 $self = SpecialPage::getTitleFor( 'Confirmemail' );
7676 $form = Xml::openElement( 'form', array( 'method' => 'post', 'action' => $self->getLocalUrl() ) );
7777 $form .= Xml::hidden( 'token', $wgUser->editToken() );
78 - $form .= Xml::submitButton( wfMsgHtml( 'confirmemail_send' ) );
 78+ $form .= Xml::submitButton( wfMsg( 'confirmemail_send' ) );
7979 $form .= Xml::closeElement( 'form' );
8080 $wgOut->addHTML( $form );
8181 }
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -3496,8 +3496,8 @@
34973497 Activate the button below to send a confirmation mail to your address.
34983498 The mail will include a link containing a code;
34993499 load the link in your browser to confirm that your e-mail address is valid.',
3500 -'confirmemail_pending' => '<div class="error">A confirmation code has already been e-mailed to you;
3501 -if you recently created your account, you may wish to wait a few minutes for it to arrive before trying to request a new code.</div>',
 3500+'confirmemail_pending' => 'A confirmation code has already been e-mailed to you;
 3501+if you recently created your account, you may wish to wait a few minutes for it to arrive before trying to request a new code.',
35023502 'confirmemail_send' => 'Mail a confirmation code',
35033503 'confirmemail_sent' => 'Confirmation e-mail sent.',
35043504 'confirmemail_oncreate' => 'A confirmation code was sent to your e-mail address.
Index: trunk/phase3/RELEASE-NOTES
@@ -69,6 +69,8 @@
7070 * (bug 16604) Show title/rev in IRC for patrol log
7171 * (bug 16854) Whether a page is being parsed as a preview or section preview
7272 can now be determined and set with ParserOptions.
 73+* Wrap message 'confirmemail_pending' into a div with CSS classes "error" and
 74+ "mw-confirmemail-pending"
7375
7476 === Bug fixes in 1.15 ===
7577 * (bug 16968) Special:Upload no longer throws useless warnings.

Comments

#Comment by Werdna (talk | contribs)   23:19, 11 February 2009

Looks okay.

Status & tagging log