r46547 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46546‎ | r46547 | r46548 >
Date:19:30, 29 January 2009
Author:btongminh
Status:reverted (Comments)
Tags:
Comment:
Also return why the target user is not valid
Modified paths:
  • /trunk/phase3/includes/api/ApiEmailUser.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiEmailUser.php
@@ -57,7 +57,7 @@
5858 if ( $targetUser instanceof User )
5959 $result = array( 'result' => 'Enabled' );
6060 else
61 - $result = array( 'result' => 'Disabled' );
 61+ $result = array( 'result' => 'Disabled', 'error' => $targetUser );
6262
6363 $this->getResult()->addValue( null, $this->getModuleName(), $result );
6464 return;
@@ -110,7 +110,7 @@
111111 'text' => 'Mail body',
112112 'token' => 'A token previously acquired via prop=info',
113113 'ccme' => 'Send a copy of this mail to me',
114 - 'check' => 'Only check whether the user has email enabled',
 114+ 'check' => 'Only check whether email can be sent to the target user',
115115 );
116116 }
117117

Comments

#Comment by Werdna (talk | contribs)   23:18, 11 February 2009

What's in $targetUser? It doesn't sound like an error message. It sounds like... a user name. If it really is a username, rather than an error message, then maybe the variable should be renamed.

#Comment by 😂 (talk | contribs)   18:39, 10 March 2009

This was reverted in r46642.

Status & tagging log