r46542 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46541‎ | r46542 | r46543 >
Date:18:00, 29 January 2009
Author:brion
Status:ok (Comments)
Tags:
Comment:
Partial revert of r45778 and friends "(bug 15936) New page's patrol button should always be visible"
The permission & patrolled checks on every view seem to be a performance problem. Have backed this out live; backing it out in SVN until resolved.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -991,19 +991,6 @@
992992 $wgOut->addWikiMsg('anontalkpagetext');
993993 }
994994
995 - # Only diffs and new page links from RC give rcid params, so if
996 - # we are just viewing the page normally with no rcid, try to find it.
997 - # This is more convenient for users.
998 - if( $this->mTitle->exists() && $this->mTitle->quickUserCan('patrol') ) {
999 - if( empty($rcid) ) {
1000 - $firstRev = $this->mTitle->getFirstRevision();
1001 - $rcid = $firstRev ? $firstRev->isUnpatrolled() : 0;
1002 - } else {
1003 - $rc = RecentChange::newFromId( $rcid );
1004 - // Already patrolled?
1005 - $rcid = is_object($rc) && !$rc->getAttribute('rc_patrolled') ? $rcid : 0;
1006 - }
1007 - }
1008995 # If we have been passed an &rcid= parameter, we want to give the user a
1009996 # chance to mark this new article as patrolled.
1010997 if( !empty($rcid) && $this->mTitle->exists() && $this->mTitle->quickUserCan('patrol') ) {
Index: trunk/phase3/RELEASE-NOTES
@@ -85,7 +85,6 @@
8686 LanguageConverter class)
8787 * (bug 17054) Added more descriptive errors in Special:RevisionDelete
8888 * (bug 11527) Diff on page with one revision shows "Next" link to same diff
89 -* (bug 15936) New page's patrol button should always be visible
9089 * (bug 8065) Fix summary forcing for new pages
9190 * (bug 10569) redirects to Special:Mypage and Special:Mytalk are no longer
9291 allowed by default. Change $wgInvalidRedirectTargets to re-enable.

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45778(Bug 15936) New page's patrol button should always be visibleaaron17:53, 15 January 2009

Comments

#Comment by Aaron Schulz (talk | contribs)   20:28, 29 January 2009

The issue can't be the permission check, since that was (and is) still done already below and is process cached.

Status & tagging log