r46537 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46536‎ | r46537 | r46538 >
Date:16:03, 29 January 2009
Author:aaron
Status:deferred (Comments)
Tags:
Comment:
Use quickUserCan rather than strange boolean param :)
Modified paths:
  • /trunk/phase3/includes/Article.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -994,7 +994,7 @@
995995 # Only diffs and new page links from RC give rcid params, so if
996996 # we are just viewing the page normally with no rcid, try to find it.
997997 # This is more convenient for users.
998 - if( $this->mTitle->exists() && $this->mTitle->userCan('patrol', false) ) {
 998+ if( $this->mTitle->exists() && $this->mTitle->quickUserCan('patrol') ) {
999999 if( empty($rcid) ) {
10001000 $firstRev = $this->mTitle->getFirstRevision();
10011001 $rcid = $firstRev ? $firstRev->isUnpatrolled() : 0;
@@ -1006,7 +1006,7 @@
10071007 }
10081008 # If we have been passed an &rcid= parameter, we want to give the user a
10091009 # chance to mark this new article as patrolled.
1010 - if( !empty($rcid) && $this->mTitle->exists() && $this->mTitle->userCan('patrol', false) ) {
 1010+ if( !empty($rcid) && $this->mTitle->exists() && $this->mTitle->quickUserCan('patrol') ) {
10111011 $wgOut->addHTML(
10121012 "<div class='patrollink'>" .
10131013 wfMsgHtml( 'markaspatrolledlink',

Comments

#Comment by Werdna (talk | contribs)   23:12, 11 February 2009

Tweak to r46495.

Status & tagging log