r46456 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46455‎ | r46456 | r46457 >
Date:17:44, 28 January 2009
Author:aaron
Status:deferred (Comments)
Tags:
Comment:
Improve table css
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/flaggedrevs.css (modified) (history)
  • /trunk/extensions/FlaggedRevs/specialpages/RatingHistory_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.php
@@ -261,7 +261,7 @@
262262 #########
263263
264264 # Bump this number every time you change flaggedrevs.css/flaggedrevs.js
265 -$wgFlaggedRevStyleVersion = 51;
 265+$wgFlaggedRevStyleVersion = 52;
266266
267267 $wgExtensionFunctions[] = 'efLoadFlaggedRevs';
268268
Index: trunk/extensions/FlaggedRevs/flaggedrevs.css
@@ -353,6 +353,15 @@
354354 font-size: 90%;
355355 }
356356
357 -.fr_reader_feedback_stats {
 357+.fr_reader_feedback_table {
 358+ margin: 1em 1em 1em 0;
 359+ background: #f9f9f9;
 360+ border: 1px #AAA solid;
 361+ border-collapse: collapse;
358362 font-size: 85%;
359363 }
 364+
 365+.fr_reader_feedback_table th, .fr_reader_feedback_table td {
 366+ border: 1px #AAA solid;
 367+ padding: 0.3em;
 368+}
Index: trunk/extensions/FlaggedRevs/specialpages/RatingHistory_body.php
@@ -678,7 +678,7 @@
679679 $wgMemc->set( $key, array( $votes, $now ), 24*3600 );
680680 }
681681 // Output multi-column list
682 - $html = "<table class='wikitable fr_reader_feedback_stats' cellspacing='0'><tr>";
 682+ $html = "<table class='fr_reader_feedback_table' cellspacing='0'><tr>";
683683 foreach( FlaggedRevs::getFeedbackTags() as $tag => $w ) {
684684 $html .= '<th>'.wfMsgHtml("readerfeedback-$tag").'</th>';
685685 }

Comments

#Comment by Werdna (talk | contribs)   22:53, 11 February 2009

Looks okay.

Status & tagging log