r46428 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46427‎ | r46428 | r46429 >
Date:06:08, 28 January 2009
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Fix group by for date sorting
Modified paths:
  • /trunk/phase3/includes/specials/SpecialListusers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialListusers.php
@@ -98,8 +98,9 @@
9999 $query = array(
100100 'tables' => " $user $useIndex LEFT JOIN $user_groups ON user_id=ug_user
101101 LEFT JOIN $ipblocks ON user_id=ipb_user AND ipb_auto=0 ",
102 - 'fields' => array('user_name',
103 - 'MAX(user_id) AS user_id',
 102+ 'fields' => array(
 103+ $this->creationSort ? 'MAX(user_name) AS user_name' : 'user_name',
 104+ $this->creationSort ? 'user_id' : 'MAX(user_id) AS user_id',
104105 'MAX(user_editcount) AS edits',
105106 'COUNT(ug_group) AS numgroups',
106107 'MAX(ug_group) AS singlegroup',

Comments

#Comment by Aaron Schulz (talk | contribs)   15:08, 29 January 2009

synced by tim, has been up and running

Status & tagging log