r46394 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46393‎ | r46394 | r46395 >
Date:22:41, 27 January 2009
Author:brion
Status:ok
Tags:
Comment:
Revert r45498 "Special:Upload can now have a custom upload message instead of uploadtext by passing "uploadmsg" parameter in the url. ... This should fix the Commons "uselang" hack on for Special:Upload."
As noted on bug, this is insufficient to cover the requirements.
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUpload.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUpload.php
@@ -1006,19 +1006,8 @@
10071007 $wgOut->addHTML( "<h2>{$sub}</h2>\n" .
10081008 "<span class='error'>{$msg}</span>\n" );
10091009 }
1010 -
1011 - $uploadMsg = $wgRequest->getVal( 'uploadmsg' );
1012 - if( $uploadMsg ) {
1013 - $uploadMsgName = 'uploadtext-' . $uploadMsg;
1014 - // Fall back to normal message if the custom messages is empty
1015 - if( wfEmptyMsg( $uploadMsgName, wfMsg( $uploadMsgName ) ) )
1016 - $uploadMsgName = 'uploadtext';
1017 - } else {
1018 - $uploadMsgName = 'uploadtext';
1019 - }
1020 -
10211010 $wgOut->addHTML( '<div id="uploadtext">' );
1022 - $wgOut->addWikiMsg( $uploadMsgName, $this->mDesiredDestName );
 1011+ $wgOut->addWikiMsg( 'uploadtext', $this->mDesiredDestName );
10231012 $wgOut->addHTML( "</div>\n" );
10241013
10251014 # Print a list of allowed file extensions, if so configured. We ignore
Index: trunk/phase3/RELEASE-NOTES
@@ -29,8 +29,6 @@
3030 === New features in 1.15 ===
3131
3232 * (bug 2242) Add an expiry time to temporary passwords
33 -* Special:Upload can now have a custom upload message instead of uploadtext by
34 - passing "uploadmsg" parameter in the url
3533 * (bug 9947) Add PROTECTIONLEVEL parser function to return the protection level
3634 for the current page for a given action
3735 * (bug 17002) Add &minor= and &summary= as parameters in the url when editing,

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45498Special:Upload can now have a custom upload message instead of uploadtext by ...ialex13:07, 7 January 2009

Status & tagging log