r46395 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r46394‎ | r46395 | r46396 >
Date:22:54, 27 January 2009
Author:brion
Status:ok
Tags:
Comment:
Roll back r46196, 46202 for now "__IGNOREUNUSED__ excludes cats from UnusedCategories (bug 17145)"
The name is very unclear; would prefer to nail that down before rolling it out.
Modified paths:
  • /trunk/phase3/CREDITS (modified) (history)
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/MagicWord.php (modified) (history)
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialUnusedcategories.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/CREDITS
@@ -56,7 +56,6 @@
5757
5858 == Patch Contributors ==
5959 * Agbad
60 -* Ahmad Sherif
6160 * Brad Jorsch
6261 * Brent G
6362 * Daniel Arnold
Index: trunk/phase3/includes/parser/Parser.php
@@ -3327,9 +3327,6 @@
33283328 wfDebug( __METHOD__.": [[MediaWiki:hidden-category-category]] is not a valid title!\n" );
33293329 }
33303330 }
3331 - if ( isset( $this->mDoubleUnderscores['ignoreunused'] ) && $this->mTitle->getNamespace() == NS_CATEGORY ) {
3332 - $this->mOutput->setProperty( 'ignoreunused', 'y' );
3333 - }
33343331 # (bug 8068) Allow control over whether robots index a page.
33353332 #
33363333 # FIXME (bug 14899): __INDEX__ always overrides __NOINDEX__ here! This
Index: trunk/phase3/includes/MagicWord.php
@@ -159,7 +159,6 @@
160160 'noeditsection',
161161 'newsectionlink',
162162 'hiddencat',
163 - 'ignoreunused',
164163 'index',
165164 'noindex',
166165 'staticredirect',
Index: trunk/phase3/includes/specials/SpecialUnusedcategories.php
@@ -22,16 +22,14 @@
2323 function getSQL() {
2424 $NScat = NS_CATEGORY;
2525 $dbr = wfGetDB( DB_SLAVE );
26 - list( $categorylinks, $page, $page_props ) = $dbr->tableNamesN( 'categorylinks', 'page', 'page_props' );
 26+ list( $categorylinks, $page ) = $dbr->tableNamesN( 'categorylinks', 'page' );
2727 return "SELECT 'Unusedcategories' as type,
2828 {$NScat} as namespace, page_title as title, page_title as value
2929 FROM $page
3030 LEFT JOIN $categorylinks ON page_title=cl_to
31 - LEFT JOIN $page_props ON (pp_page=page_id AND pp_propname = 'ignoreunused')
3231 WHERE cl_from IS NULL
3332 AND page_namespace = {$NScat}
34 - AND page_is_redirect = 0
35 - AND pp_propname IS NULL";
 33+ AND page_is_redirect = 0";
3634 }
3735
3836 function formatResult( $skin, $result ) {
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -328,7 +328,6 @@
329329 'filepath' => array( 0, 'FILEPATH:' ),
330330 'tag' => array( 0, 'tag' ),
331331 'hiddencat' => array( 1, '__HIDDENCAT__' ),
332 - 'ignoreunused' => array( 1, '__IGNOREUNUSED__' ),
333332 'pagesincategory' => array( 1, 'PAGESINCATEGORY', 'PAGESINCAT' ),
334333 'pagesize' => array( 1, 'PAGESIZE' ),
335334 'index' => array( 1, '__INDEX__' ),
Index: trunk/phase3/RELEASE-NOTES
@@ -58,8 +58,6 @@
5959 link instead of Go button & Search button
6060 * (bug 2314) Add links to user custom CSS and JS to Special:Preferences
6161 * More helpful error message on raw page access if PHP_SELF isn't set
62 -* (bug 17145) Specific categories can be excluded from Special:UnusedCategories
63 - with __IGNOREUNUSED__
6462 * (bug 13040) Gender switch in user preferences
6563 * (bug 13040) {{GENDER:}} magic word for interface messages
6664 * (bug 3301) Optionally sort user list according to account creation time

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r46196__IGNOREUNUSED__ excludes cats from UnusedCategories...simetrical12:43, 25 January 2009

Status & tagging log