r45967 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45966‎ | r45967 | r45968 >
Date:16:07, 21 January 2009
Author:ialex
Status:deferred
Tags:
Comment:
Fixed a bug on Special:Extensions, default settings values are now correctly displayed.
Modified paths:
  • /trunk/extensions/Configure/CHANGELOG (modified) (history)
  • /trunk/extensions/Configure/Configure.php (modified) (history)
  • /trunk/extensions/Configure/SpecialExtensions.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/CHANGELOG
@@ -1,6 +1,10 @@
22 This file lists changes on this extension.
33 Localisation updates are done on betawiki and aren't listed here.
44
 5+0.11.12 - 21 January 2009
 6+ Fixed a bug on Special:Extensions, default settings values are now correctly
 7+ displayed.
 8+
59 0.11.11 - 19 January 2009
610 Added support for StalePages extension.
711
Index: trunk/extensions/Configure/Configure.php
@@ -17,7 +17,7 @@
1818 'url' => 'http://www.mediawiki.org/wiki/Extension:Configure',
1919 'description' => 'Allow authorised users to configure the wiki via a web-based interface',
2020 'descriptionmsg' => 'configure-desc',
21 - 'version' => '0.11.11',
 21+ 'version' => '0.11.12',
2222 );
2323
2424 # Configuration part
Index: trunk/extensions/Configure/SpecialExtensions.php
@@ -105,14 +105,14 @@
106106 $globalDone = true;
107107 }
108108 require_once( $ext->getFile() );
109 - if ( isset( $GLOBALS[$setting] ) )
110 - $this->conf[$setting] = $GLOBALS[$setting];
 109+ if ( isset( $$setting ) )
 110+ $this->conf[$setting] = $$setting;
111111 }
112112 }
113113 $ext->setPageObj( $this );
114114 $ret .= $ext->getHtml();
115115 }
116 - if ( isset( $oldHooks ) )
 116+ if ( $globalDone )
117117 $GLOBALS['wgHooks'] = $oldHooks;
118118 return $ret;
119119 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r45968* Fix for r45967, include extensions settings in ConfigurationSettings::getEd...ialex19:50, 21 January 2009
r45976Backport r45967, r45968 and r45975ialex20:57, 21 January 2009

Status & tagging log