r45831 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45830‎ | r45831 | r45832 >
Date:10:11, 17 January 2009
Author:catrope
Status:reverted
Tags:
Comment:
Another followup to r45819: update references to the renamed archive.usertext_timestamp index. The user_newtalk.user_id and user_newtalk.user_ip indices aren't used anywhere that I could find.
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryDeletedrevs.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialDeletedContributions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryDeletedrevs.php
@@ -151,7 +151,7 @@
152152 }
153153
154154 $this->addOption('LIMIT', $limit + 1);
155 - $this->addOption('USE INDEX', array('archive' => ($mode == 'user' ? 'usertext_timestamp' : 'name_title_timestamp')));
 155+ $this->addOption('USE INDEX', array('archive' => ($mode == 'user' ? 'ar_usertext_timestamp' : 'name_title_timestamp')));
156156 if($mode == 'all')
157157 {
158158 if($params['unique'])
Index: trunk/phase3/includes/specials/SpecialDeletedContributions.php
@@ -44,7 +44,7 @@
4545 $condition = array();
4646
4747 $condition['ar_user_text'] = $this->target;
48 - $index = 'usertext_timestamp';
 48+ $index = 'ar_usertext_timestamp';
4949
5050 return array( $index, $condition );
5151 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r45891Revert r45821, r45830, r45831 and r45835 all in order to revert r45819, per d...catrope13:56, 19 January 2009

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45819Attempt at cleaning up r45764, r45769 (renamed indices for SQLite compat):...catrope23:02, 16 January 2009

Status & tagging log