r45463 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45462‎ | r45463 | r45464 >
Date:22:10, 6 January 2009
Author:raymond
Status:ok (Comments)
Tags:
Comment:
Add new messages 'movepage-moved-redirect' and 'movepage-moved-noredirect' per http://www.mediawiki.org/wiki/Special:Code/MediaWiki/45288#c1135
Modified paths:
  • /trunk/phase3/includes/specials/SpecialMovepage.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -1881,6 +1881,8 @@
18821882 'movepagebtn',
18831883 'pagemovedsub',
18841884 'movepage-moved',
 1885+ 'movepage-moved-redirect',
 1886+ 'movepage-moved-noredirect',
18851887 'articleexists',
18861888 'cantmove-titleprotected',
18871889 'talkexists',
Index: trunk/phase3/includes/specials/SpecialMovepage.php
@@ -349,7 +349,9 @@
350350 $oldLink = "<span class='plainlinks'>[$oldUrl $oldText]</span>";
351351 $newLink = "<span class='plainlinks'>[$newUrl $newText]</span>";
352352
 353+ $msgName = $createRedirect ? 'movepage-moved-redirect' : 'movepage-moved-noredirect';
353354 $wgOut->addWikiMsg( 'movepage-moved', $oldLink, $newLink, $oldText, $newText );
 355+ $wgOut->addWikiMsg( $msgName );
354356
355357 # Now we move extra pages we've been asked to move: subpages and talk
356358 # pages. First, if the old page or the new page is a talk page, we
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2704,6 +2704,8 @@
27052705 'movepagebtn' => 'Move page',
27062706 'pagemovedsub' => 'Move succeeded',
27072707 'movepage-moved' => '<big>\'\'\'"$1" has been moved to "$2"\'\'\'</big>', # The two titles are passed in plain text as $3 and $4 to allow additional goodies in the message.
 2708+'movepage-moved-redirect' => 'A redirect has been created.',
 2709+'movepage-moved-noredirect' => 'The creation of a redirect has been suppressed.',
27082710 'articleexists' => 'A page of that name already exists, or the name you have chosen is not valid.
27092711 Please choose another name.',
27102712 'cantmove-titleprotected' => 'You cannot move a page to this location, because the new title has been protected from creation',

Comments

#Comment by Raymond (talk | contribs)   18:38, 18 October 2011

Just for the records: That was bug 16128.

Status & tagging log