r45432 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45431‎ | r45432 | r45433 >
Date:02:50, 6 January 2009
Author:danny_b
Status:reverted (Comments)
Tags:
Comment:
* Added "Advanced search" link to the search form
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/skins/CologneBlue.php (modified) (history)
  • /trunk/phase3/skins/Modern.php (modified) (history)
  • /trunk/phase3/skins/MonoBook.php (modified) (history)
  • /trunk/phase3/skins/monobook/main.css (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/monobook/main.css
@@ -715,7 +715,9 @@
716716 padding: .5em .4em .4em .4em;
717717 text-align: center;
718718 }
719 -
 719+#p-search a {
 720+ font-size: 95%;
 721+}
720722 /*
721723 ** the personal toolbar
722724 */
Index: trunk/phase3/skins/CologneBlue.php
@@ -299,7 +299,8 @@
300300 $s .= "<input type='text' id=\"searchInput{$this->searchboxes}\" class=\"mw-searchInput\" name=\"search\" size=\"14\" value=\""
301301 . htmlspecialchars(substr($search,0,256)) . "\" /><br />"
302302 . "<input type='submit' id=\"searchGoButton{$this->searchboxes}\" class=\"searchButton\" name=\"go\" value=\"" . htmlspecialchars( wfMsg( "searcharticle" ) ) . "\" />"
303 - . "<input type='submit' id=\"mw-searchButton{$this->searchboxes}\" class=\"searchButton\" name=\"fulltext\" value=\"" . htmlspecialchars( wfMsg( "search" ) ) . "\" /></form>";
 303+ . "<input type='submit' id=\"mw-searchButton{$this->searchboxes}\" class=\"searchButton\" name=\"fulltext\" value=\"" . htmlspecialchars( wfMsg( "search" ) ) . "\" />\n"
 304+ . '<a href="' . wfMsg ('searchaction') . '" rel="search">' . wfMsg ('powersearch-legend') . '</a></form>';
304305
305306 // Ensure unique id's for search boxes made after the first
306307 $this->searchboxes = $this->searchboxes == '' ? 2 : $this->searchboxes + 1;
Index: trunk/phase3/skins/MonoBook.php
@@ -259,6 +259,7 @@
260260 ?> value="<?php $this->text('search') ?>"<?php } ?> />
261261 <input type='submit' name="go" class="searchButton" id="searchGoButton" value="<?php $this->msg('searcharticle') ?>"<?php echo $this->skin->tooltipAndAccesskey( 'search-go' ); ?> />&nbsp;
262262 <input type='submit' name="fulltext" class="searchButton" id="mw-searchButton" value="<?php $this->msg('searchbutton') ?>"<?php echo $this->skin->tooltipAndAccesskey( 'search-fulltext' ); ?> />
 263+ <a href="<?php $this->text('searchaction') ?>" rel="search"><?php $this->msg('powersearch-legend') ?></a>
263264 </div></form>
264265 </div>
265266 </div>
Index: trunk/phase3/skins/Modern.php
@@ -256,6 +256,7 @@
257257 ?> value="<?php $this->text('search') ?>"<?php } ?> />
258258 <input type='submit' name="go" class="searchButton" id="searchGoButton" value="<?php $this->msg('searcharticle') ?>"<?php echo $this->skin->tooltipAndAccesskey( 'search-go' ); ?> />&nbsp;
259259 <input type='submit' name="fulltext" class="searchButton" id="mw-searchButton" value="<?php $this->msg('searchbutton') ?>"<?php echo $this->skin->tooltipAndAccesskey( 'search-fulltext' ); ?> />
 260+ <a href="<?php $this->text('searchaction') ?>" rel="search"><?php $this->msg('powersearch-legend') ?></a>
260261 </div></form>
261262 </div><!-- pBody -->
262263 </div><!-- portlet -->
Index: trunk/phase3/includes/DefaultSettings.php
@@ -1446,7 +1446,7 @@
14471447 * to ensure that client-side caches don't keep obsolete copies of global
14481448 * styles.
14491449 */
1450 -$wgStyleVersion = '195';
 1450+$wgStyleVersion = '196';
14511451
14521452
14531453 # Server-side caching:
Index: trunk/phase3/includes/Skin.php
@@ -1148,7 +1148,8 @@
11491149 . '<input type="text" id="searchInput'.$this->searchboxes.'" name="search" size="19" value="'
11501150 . htmlspecialchars(substr($search,0,256)) . "\" />\n"
11511151 . '<input type="submit" name="go" value="' . wfMsg ('searcharticle') . '" />&nbsp;'
1152 - . '<input type="submit" name="fulltext" value="' . wfMsg ('searchbutton') . "\" />\n</form>";
 1152+ . '<input type="submit" name="fulltext" value="' . wfMsg ('searchbutton') . "\" />\n"
 1153+ . '<a href="' . wfMsg ('searchaction') . '" rel="search">' . wfMsg ('powersearch-legend') . '</a></form>';
11531154
11541155 // Ensure unique id's for search boxes made after the first
11551156 $this->searchboxes = $this->searchboxes == '' ? 2 : $this->searchboxes + 1;
Index: trunk/phase3/RELEASE-NOTES
@@ -257,6 +257,7 @@
258258 move log
259259 * Image moving is now enabled for sysops by default
260260 * Make "Did you mean" search feature more noticeable
 261+* Added "Advanced search" link to the search form
261262
262263 === Bug fixes in 1.14 ===
263264

Follow-up revisions

RevisionCommit summaryAuthorDate
r45483Revert r45432 "* Added "Advanced search" link to the search form"...brion03:37, 7 January 2009

Comments

#Comment by Brion VIBBER (talk | contribs)   03:37, 7 January 2009

Reverted in r45483 -- link href makes no sense.

#Comment by Danny B. (talk | contribs)   04:59, 7 January 2009

My fault, too much copypasting ;-), sorry.

Re-added fixed in r45490.

Status & tagging log