r45374 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r45373‎ | r45374 | r45375 >
Date:16:40, 3 January 2009
Author:aaron
Status:ok (Comments)
Tags:todo 
Comment:
(bug 16579) Check if session is set
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
——@@ -2321,7 +2321,7 @@
23222322
23232323 wfRunHooks( 'UserSetCookies', array( $this, &$session, &$cookies ) );
23242324 #check for null, since the hook could cause a null value
2325 - if ( !is_null( $session ) && !is_null( $_SESSION ) ){
 2325+ if ( !is_null( $session ) && isset( $_SESSION ) ){
23262326 $_SESSION = $session + $_SESSION;
23272327 }
23282328 foreach ( $cookies as $name => $value ) {

Comments

#Comment by Brion VIBBER (talk | contribs)   02:17, 7 January 2009

Uh? This doesn't appear to change anything.

#Comment by Brion VIBBER (talk | contribs)   04:29, 7 January 2009

Change is fine, just won't alter any behavior... reopened bug.

Status & tagging log