r45263 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45262‎ | r45263 | r45264 >
Date:23:13, 31 December 2008
Author:brion
Status:ok
Tags:
Comment:
Fix for r45089 -- return original diff data, not the compressed form, when doing an on-demand diff load and storing it to DB.
Modified paths:
  • /trunk/extensions/CodeReview/CodeRepository.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/CodeRepository.php
@@ -225,10 +225,11 @@
226226 // Store to cache
227227 $wgMemc->set( $key, $data, 3600*24*3 );
228228 // Permanent DB storage
229 - $flags = Revision::compressRevisionText( $data );
 229+ $storedData = $data;
 230+ $flags = Revision::compressRevisionText( $storedData );
230231 $dbw = wfGetDB( DB_MASTER );
231232 $dbw->update( 'code_rev',
232 - array( 'cr_diff' => $data, 'cr_flags' => $flags ),
 233+ array( 'cr_diff' => $storedData, 'cr_flags' => $flags ),
233234 array( 'cr_repo_id' => $this->mId, 'cr_id' => $rev ),
234235 __METHOD__
235236 );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45089(bug 16774) Save CodeReview diffs to database instead of transitory cacheaaron13:32, 27 December 2008

Status & tagging log