r45250 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45249‎ | r45250 | r45251 >
Date:20:46, 31 December 2008
Author:brion
Status:ok
Tags:
Comment:
Follow-up to r45158
* Rename 'ellipsis-separator' to just 'ellipsis'. Clearer, since it's not really a separator ;) and shorter so people will be more likely to use it!
* Use wfMsgForContent() in MWSearch, since we're using it in the context of page content the ellipsis should match content language.
Modified paths:
  • /trunk/extensions/MWSearch/MWSearch_body.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesBs.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -2677,7 +2677,7 @@
26782678 'autocomment-prefix',
26792679 'pipe-separator',
26802680 'word-separator',
2681 - 'ellipsis-separator',
 2681+ 'ellipsis',
26822682 ),
26832683 'imgmulti' => array(
26842684 'imgmultipageprev',
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -3537,7 +3537,7 @@
35383538 'autocomment-prefix' => '- ', # only translate this message to other languages if you have to change it
35393539 'pipe-separator' => '|', # only translate this message to other languages if you have to change it
35403540 'word-separator' => ' ', # only translate this message to other languages if you have to change it
3541 -'ellipsis-separator' => '…', # only translate this message to other languages if you have to change it
 3541+'ellipsis' => '…', # only translate this message to other languages if you have to change it
35423542
35433543 # Multipage image navigation
35443544 'imgmultipageprev' => '← previous page',
Index: trunk/phase3/languages/messages/MessagesBs.php
@@ -2951,7 +2951,6 @@
29522952 'autocomment-prefix' => '- ',
29532953 'pipe-separator' => '|',
29542954 'word-separator' => ' ',
2955 -'ellipsis-separator' => '…',
29562955
29572956 # Multipage image navigation
29582957 'imgmultipageprev' => '← prethodna stranica',
Index: trunk/extensions/MWSearch/MWSearch_body.php
@@ -324,7 +324,7 @@
325325 $start = 0;
326326 $snippet = "";
327327 $hi = 0;
328 - $ellipsis = wfMsg( 'ellipsis-separator' );
 328+ $ellipsis = wfMsgForContent( 'ellipsis' );
329329
330330 foreach($splits as $sp){
331331 $sp = intval($sp);

Follow-up revisions

RevisionCommit summaryAuthorDate
r45252Follow up on incomplete r45250siebrand21:09, 31 December 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45158* Add a new message for an ellipsis...raymond18:36, 29 December 2008

Status & tagging log