r45227 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45226‎ | r45227 | r45228 >
Date:17:02, 31 December 2008
Author:brion
Status:ok (Comments)
Tags:
Comment:
Revert r45189 "Escape entities in h1 title html" -- double-escaping
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/SkinTemplate.php
@@ -183,7 +183,7 @@
184184 wfProfileOut( __METHOD__."-stuff" );
185185
186186 wfProfileIn( __METHOD__."-stuff2" );
187 - $tpl->set( 'title', htmlspecialchars( $out->getPageTitle() ) );
 187+ $tpl->set( 'title', $out->getPageTitle() );
188188 $tpl->set( 'pagetitle', $out->getHTMLTitle() );
189189 $tpl->set( 'displaytitle', $out->mPageLinkTitle );
190190 $tpl->set( 'pageclass', $this->getPageClasses( $this->mTitle ) );
Index: trunk/phase3/includes/Skin.php
@@ -1013,7 +1013,7 @@
10141014
10151015 function pageTitle() {
10161016 global $wgOut;
1017 - $s = '<h1 class="pagetitle">' . htmlspecialchars( $wgOut->getPageTitle() ) . '</h1>';
 1017+ $s = '<h1 class="pagetitle">' . $wgOut->getPageTitle() . '</h1>';
10181018 return $s;
10191019 }
10201020

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r45189Escape entities in h1 title htmlaaron16:09, 30 December 2008

Comments

#Comment by Aaron Schulz (talk | contribs)   17:15, 31 December 2008

Yeah, that was part of r45181 and the lot

Status & tagging log