r45194 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45193‎ | r45194 | r45195 >
Date:18:43, 30 December 2008
Author:brion
Status:ok
Tags:
Comment:
Cleanup to r44993 -- avoid using '$x = foo()' in an if() condition on general principle. :)
Modified paths:
  • /trunk/phase3/includes/ChangesList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ChangesList.php
@@ -362,8 +362,11 @@
363363 # Edit/log timestamp
364364 $this->insertTimestamp( $s, $rc );
365365 # Bytes added or removed
366 - if( $wgRCShowChangedSize && ($cd = $rc->getCharacterDifference()) ) {
367 - $s .= "$cd . . ";
 366+ if( $wgRCShowChangedSize ) {
 367+ $cd = $rc->getCharacterDifference();
 368+ if( $cd != '' ) {
 369+ $s .= "$cd . . ";
 370+ }
368371 }
369372 # User tool links
370373 $this->insertUserRelatedLinks($s,$rc);

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r44993* Don't rebuild the character size html twice...aaron23:59, 23 December 2008

Status & tagging log