r45195 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45194‎ | r45195 | r45196 >
Date:18:53, 30 December 2008
Author:brion
Status:ok
Tags:
Comment:
Cleanup to r44994 -- use __METHOD__ rather than __FUNCTION__ in wfDeprecated() calls in constructors for deprecated classes. __FUNCTION__ will return only "__construct" which ain't quite what we want. :)
Modified paths:
  • /trunk/phase3/includes/LogEventsList.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogEventsList.php
@@ -713,7 +713,7 @@
714714 */
715715 function __construct( $request ) {
716716 global $wgUser, $wgOut;
717 - wfDeprecated(__FUNCTION__);
 717+ wfDeprecated(__METHOD__);
718718 # Get parameters
719719 $type = $request->getVal( 'type' );
720720 $user = $request->getText( 'user' );
@@ -760,7 +760,7 @@
761761 */
762762 function __construct( &$reader, $flags = 0 ) {
763763 global $wgUser;
764 - wfDeprecated(__FUNCTION__);
 764+ wfDeprecated(__METHOD__);
765765 $this->reader =& $reader;
766766 $this->reader->pager->mLogEventsList->flags = $flags;
767767 # Aliases for shorter code...

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r44994Whitespace/line breaks to keep this decent lookingaaron00:09, 24 December 2008

Status & tagging log