r45021 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r45020‎ | r45021 | r45022 >
Date:12:11, 25 December 2008
Author:danny_b
Status:reverted (Comments)
Tags:
Comment:
* reverting r44896 - it causes massive invalidity of pages. See http://www.w3.org/TR/html401/types.html#type-name and http://www.w3.org/TR/xhtml1/#C_8 for definitions of "id" and "name" content.
Modified paths:
  • /trunk/phase3/includes/Linker.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Linker.php
@@ -1519,7 +1519,7 @@
15201520 * @return string HTML headline
15211521 */
15221522 public function makeHeadline( $level, $attribs, $anchor, $text, $link ) {
1523 - return "<a name=\"$anchor\" id=\"$anchor\"></a><h$level$attribs$link <span class=\"mw-headline\">$text</span></h$level>";
 1523+ return "<a name=\"$anchor\"></a><h$level$attribs$link <span class=\"mw-headline\">$text</span></h$level>";
15241524 }
15251525
15261526 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r45022* reverting r44927 because of r45021danny_b12:21, 25 December 2008
r45023* reverting r44896 because of r45021danny_b12:40, 25 December 2008
r45044Revert r45021, r45022, r45023 -- restoring r44896, r44927, r44896 -- pending ...brion05:28, 26 December 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r44896Add "id" attribute to section anchors, per discussion on wikitech-l.vyznev11:45, 22 December 2008

Comments

#Comment by Brion VIBBER (talk | contribs)   05:31, 26 December 2008

Reverted in r45044

Status & tagging log