r44978 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r44977‎ | r44978 | r44979 >
Date:21:42, 23 December 2008
Author:aaron
Status:reverted (Comments)
Tags:
Comment:
At least disable old xml function loading per r44839. An easy ~9-10ms.
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
——@@ -9,7 +9,7 @@
1010 */
1111
1212 require_once dirname(__FILE__) . '/normal/UtfNormalUtil.php';
13 -require_once dirname(__FILE__) . '/XmlFunctions.php';
 13+#require_once dirname(__FILE__) . '/XmlFunctions.php';
1414
1515 // Hide compatibility functions from Doxygen
1616 /// @cond

Follow-up revisions

RevisionCommit summaryAuthorDate
r44982Revert r44978 -- breaks back-compatbrion22:04, 23 December 2008

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r44839Search & replace war on old wf* xml functionsaaron09:32, 20 December 2008

Comments

#Comment by Brion VIBBER (talk | contribs)   22:05, 23 December 2008

Reverted in r44982, breaks backwards compatibility.

(Consider separating the top-level compat functions from the class definition if load time without an opcode cache is a concern.)

Status & tagging log