r44793 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44792‎ | r44793 | r44794 >
Date:02:26, 19 December 2008
Author:brion
Status:ok
Tags:
Comment:
Bug 13893 -- add IDs for some more form controls on HideRevision for good measure.
Modified paths:
  • /trunk/extensions/Oversight/HideRevision_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Oversight/HideRevision_body.php
@@ -72,7 +72,7 @@
7373 "<br />" .
7474 Xml::inputLabel( wfMsgHTML( 'hiderevision-reason' ), 'wpReason', 'wpReason', 60 ) .
7575 "<br />" .
76 - Xml::submitButton( wfMsgHTML( 'hiderevision-continue' ) ) .
 76+ Xml::submitButton( wfMsgHTML( 'hiderevision-continue' ), array( 'id' => 'mw-hiderevision-continue' ) ) .
7777
7878 Xml::closeElement( 'form' ) );
7979 }
@@ -99,7 +99,7 @@
100100 "<br />" .
101101 Xml::inputLabel( wfMsgHTML( 'hiderevision-reason' ), 'wpReason', 'wpReason', 60, $this->mReason ) .
102102 "<br />" .
103 - Xml::submitButton( wfMsgHTML( 'hiderevision-submit' ) ) .
 103+ Xml::submitButton( wfMsgHTML( 'hiderevision-submit' ), array( 'id' => 'mw-hiderevision-submit' ) ) .
104104
105105 // Hidden fields
106106 $this->revisionFields() .
@@ -396,12 +396,12 @@
397397 $wgOut->addHTML( "<form action=\"$action\" method=\"get\"><fieldset>" );
398398 $wgOut->addHTML( '<legend>' . wfMsgHtml('oversight-legend') . '</legend>' );
399399 $wgOut->addHTML( Xml::hidden( 'title', $wgTitle->getPrefixedDbKey() ) );
400 - $wgOut->addHTML( Xml::inputLabel( wfMsg( 'oversight-oversighter' ), 'user', 'user', 20, $user ) );
 400+ $wgOut->addHTML( Xml::inputLabel( wfMsg( 'oversight-oversighter' ), 'user', 'mw-oversight-user', 20, $user ) );
401401 $wgOut->addHTML( '&nbsp;' );
402 - $wgOut->addHTML( Xml::inputLabel( wfMsg( 'speciallogtitlelabel' ), 'page', 'page', 25, $page ) );
 402+ $wgOut->addHTML( Xml::inputLabel( wfMsg( 'speciallogtitlelabel' ), 'page', 'mw-oversight-page', 25, $page ) );
403403 $wgOut->addHTML( '&nbsp;' );
404 - $wgOut->addHTML( Xml::inputLabel( wfMsg( 'oversight-offender' ), 'author', 'author', 20, $offender ) );
405 - $wgOut->addHTML( '&nbsp;' . Xml::submitButton( wfMsg( 'allpagessubmit' ) ) );
 404+ $wgOut->addHTML( Xml::inputLabel( wfMsg( 'oversight-offender' ), 'author', 'mw-oversight-author', 20, $offender ) );
 405+ $wgOut->addHTML( '&nbsp;' . Xml::submitButton( wfMsg( 'allpagessubmit' ), array( 'id' => 'mw-oversight-submit' ) ) );
406406 $wgOut->addHTML( '</fieldset></form>' );
407407
408408 $pager = new HiddenRevisionsPager( $this, array(), $title, $u, $offender );

Status & tagging log