r44792 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44791‎ | r44792 | r44793 >
Date:02:03, 19 December 2008
Author:brion
Status:ok
Tags:
Comment:
* (bug 11733) Fixed parameter validation in importTextFile.php
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/maintenance/importTextFile.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/importTextFile.php
@@ -24,19 +24,19 @@
2525
2626 $title = isset( $options['title'] ) ? $options['title'] : titleFromFilename( $filename );
2727 $title = Title::newFromUrl( $title );
28 - echo( "\nUsing title '" . $title->getPrefixedText() . "'..." );
2928
3029 if( is_object( $title ) ) {
3130
 31+ echo( "\nUsing title '" . $title->getPrefixedText() . "'..." );
3232 if( !$title->exists() || !isset( $options['nooverwrite'] ) ) {
3333
3434 $text = file_get_contents( $filename );
3535 $user = isset( $options['user'] ) ? $options['user'] : 'Maintenance script';
3636 $user = User::newFromName( $user );
37 - echo( "\nUsing username '" . $user->getName() . "'..." );
3837
3938 if( is_object( $user ) ) {
4039
 40+ echo( "\nUsing username '" . $user->getName() . "'..." );
4141 $wgUser =& $user;
4242 $comment = isset( $options['comment'] ) ? $options['comment'] : 'Importing text file';
4343 $flags = 0 | ( isset( $options['norc'] ) ? EDIT_SUPPRESS_RC : 0 );
Index: trunk/phase3/RELEASE-NOTES
@@ -430,6 +430,7 @@
431431 images which do not specify width and height attributes.
432432 * (bug 15027) Internet domain names and IP addresses can now be indexed and
433433 searched sensibly with the default MySQL search backend.
 434+* (bug 11733) Fixed parameter validation in importTextFile.php
434435
435436 === API changes in 1.14 ===
436437

Status & tagging log