r44777 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r44776‎ | r44777 | r44778 >
Date:20:36, 18 December 2008
Author:aaron
Status:ok (Comments)
Tags:
Comment:
Fix odd syntax that made XHTML error
Modified paths:
  • /trunk/phase3/includes/specials/SpecialSearch.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialSearch.php
——@@ -607,10 +607,8 @@
608608
609609 $redirectText = '';
610610 // show redirects check only if backend supports it
611 - if($this->searchEngine->acceptListRedirects()){
612 - "<p>".
613 - $redirectText = $redirect . " " . $redirectLabel
614 - ."</p>";
 611+ if( $this->searchEngine->acceptListRedirects() ) {
 612+ $redirectText = "<p>". $redirect . " " . $redirectLabel ."</p>";
615613 }
616614
617615 $out = Xml::openElement( 'form', array( 'id' => 'powersearch', 'method' => 'get', 'action' => $wgScript ) ) .

Comments

#Comment by Rainman (talk | contribs)   21:25, 20 December 2008

Indeed, thanks Aaron.

I think this is as good at it will get with the new search ui, so might be ready for some official testing.

Status & tagging log