r44706 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r44705‎ | r44706 | r44707 >
Date:07:42, 17 December 2008
Author:tstarling
Status:ok (Comments)
Tags:
Comment:
Is this needed? Probably not, but it doesn't hurt. The connection is only used for reading, so the commitMasterChanges() is technically unnecessary but harmless. Without closeAll(), the connection will be held open until the script terminates, but that's probably pretty soon in this case.
Modified paths:
  • /trunk/phase3/maintenance/FiveUpgrade.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/FiveUpgrade.inc
——@@ -77,8 +77,7 @@
7878 }
7979
8080 /**
81 - * Close out the connections when we're done...
82 - * Is this needed?
 81+ * Commit transactions and close the connections when we're done...
8382 */
8483 function close() {
8584 foreach( $this->loadBalancers as $lb ) {

Comments

#Comment by Brion VIBBER (talk | contribs)   18:15, 23 December 2008

Yeah, I threw it in to be used if needed, but it won't be called by default. Scripts that do use it could call it if they wanted though.

Status & tagging log