r44696 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44695‎ | r44696 | r44697 >
Date:00:05, 17 December 2008
Author:brion
Status:ok
Tags:
Comment:
Reverting r44681 "Throw in quick hack $wgRateLimitsExcludedIPs so we don't have to do a live hack every time somebody runs an exciting event where they're going to register a lot of accounts."
r44592 (bug 7492) seems to cover this case with an extension to autopromote settings. Future on-wiki stuff still would be nice...
Modified paths:
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/User.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -1146,17 +1146,10 @@
11471147 */
11481148 public function isPingLimitable() {
11491149 global $wgRateLimitsExcludedGroups;
1150 - global $wgRateLimitsExcludedIPs;
11511150 if( array_intersect( $this->getEffectiveGroups(), $wgRateLimitsExcludedGroups ) ) {
11521151 // Deprecated, but kept for backwards-compatibility config
11531152 return false;
11541153 }
1155 - if( in_array( wfGetIP(), $wgRateLimitsExcludedIPs ) ) {
1156 - // No other good way currently to disable rate limits
1157 - // for specific IPs. :P
1158 - // But this is a crappy hack and should die.
1159 - return false;
1160 - }
11611154 return !$this->isAllowed('noratelimit');
11621155 }
11631156
Index: trunk/phase3/includes/DefaultSettings.php
@@ -3206,16 +3206,6 @@
32073207 $wgRateLimitsExcludedGroups = array();
32083208
32093209 /**
3210 - * Array of IPs which should never trigger the rate limiter.
3211 - * Really this is a cruddy hack and should be replaced with
3212 - * an "anti-block" or something which can be managed through
3213 - * the wiki UI.
3214 - *
3215 - * $wgRateLimitsExcludedIPs = array( '1.2.3.4' );
3216 - */
3217 -$wgRateLimitsExcludedIPs = array();
3218 -
3219 -/**
32203210 * On Special:Unusedimages, consider images "used", if they are put
32213211 * into a category. Default (false) is not to count those as used.
32223212 */

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r44592(bug 7492) Allow assignment of rights to specific IPs/rangesdemon20:49, 14 December 2008
r44681Throw in quick hack $wgRateLimitsExcludedIPs so we don't have to do a live hack...brion18:43, 16 December 2008

Status & tagging log