r44695 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44694‎ | r44695 | r44696 >
Date:00:00, 17 December 2008
Author:werdna
Status:ok
Tags:
Comment:
Fix broken and double escaping in r44657.
Modified paths:
  • /trunk/phase3/includes/LogEventsList.php (modified) (history)
  • /trunk/phase3/includes/specials/SpecialIpblocklist.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/LogEventsList.php
@@ -273,10 +273,10 @@
274274 $this->skin->link( SpecialPage::getTitleFor( 'Ipblocklist' ),
275275 $this->message['unblocklink'],
276276 array(),
277 - array( 'action' => 'unblock', 'ip' => urlencode( $row->log_title ) ),
 277+ array( 'action' => 'unblock', 'ip' => $row->log_title ),
278278 'known' )
279279 . ' ' . wfMsg( 'pipe-separator' ) . ' ' .
280 - $this->skin->link( SpecialPage::getTitleFor( 'Blockip', htmlspecialchars( $row->log_title ) ),
 280+ $this->skin->link( SpecialPage::getTitleFor( 'Blockip', $row->log_title ),
281281 $this->message['change-blocklink'],
282282 array(), array(), 'known' ) .
283283 ')';
Index: trunk/phase3/includes/specials/SpecialIpblocklist.php
@@ -428,13 +428,13 @@
429429 $unblocklink = $sk->link( SpecialPage::getTitleFor( 'Ipblocklist' ),
430430 $msg['unblocklink'],
431431 array(),
432 - array( 'action' => 'unblock', 'id' => urlencode( $block->mId ) ),
 432+ array( 'action' => 'unblock', 'id' => $block->mId ),
433433 'known' );
434434
435435 # Create changeblocklink for all blocks with exception of autoblocks
436436 if( !$block->mAuto ) {
437437 $changeblocklink = ' ' . wfMsg( 'pipe-separator' ) . ' ' .
438 - $sk->link( SpecialPage::getTitleFor( 'Blockip', htmlspecialchars( $block->mAddress ) ),
 438+ $sk->link( SpecialPage::getTitleFor( 'Blockip', $block->mAddress ),
439439 $msg['change-blocklink'],
440440 array(), array(), 'known' );
441441 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r44657* Add a 'change block' link to Special:IPBlockList und Special:Lograymond08:51, 16 December 2008

Status & tagging log