r44586 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44585‎ | r44586 | r44587 >
Date:17:44, 14 December 2008
Author:catrope
Status:ok
Tags:
Comment:
Follow-up to r44584: finishing comment.
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryAllpages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryAllpages.php
@@ -117,7 +117,8 @@
118118 $this->addTables('langlinks');
119119 $this->addWhere('page_id=ll_from');
120120 $this->addOption('STRAIGHT_JOIN');
121 - // We have to GROUP BY
 121+ // We have to GROUP BY all selected fields to stop
 122+ // PostgreSQL from whining
122123 $this->addOption('GROUP BY', implode(', ', $selectFields));
123124 $forceNameTitleIndex = false;
124125 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r44584API: (bug 16549) Kill a filesort in list=allpages&apfilterlanglinks=withlangl...catrope17:04, 14 December 2008

Status & tagging log