r44587 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44586‎ | r44587 | r44588 >
Date:18:41, 14 December 2008
Author:ialex
Status:ok
Tags:
Comment:
* removed useless check for $wgAllowUserSkin since we're already checked for it 18 lines above
* wfHidden() -> Xml::hidden()
Modified paths:
  • /trunk/phase3/includes/specials/SpecialPreferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialPreferences.php
@@ -783,7 +783,7 @@
784784 } else {
785785 # Need to output a hidden option even if the relevant skin is not in use,
786786 # otherwise the preference will get reset to 0 on submit
787 - $wgOut->addHTML( wfHidden( 'wpQuickbar', $this->mQuickbar ) );
 787+ $wgOut->addHTML( Xml::hidden( 'wpQuickbar', $this->mQuickbar ) );
788788 }
789789
790790 # Skin
@@ -807,7 +807,7 @@
808808 foreach ($validSkinNames as $skinkey => $sn ) {
809809 $checked = $skinkey == $this->mSkin ? ' checked="checked"' : '';
810810 $mplink = htmlspecialchars($mptitle->getLocalURL("useskin=$skinkey"));
811 - $previewlink = $wgAllowUserSkin ? "(<a target='_blank' href=\"$mplink\">$previewtext</a>)" : '';
 811+ $previewlink = "(<a target='_blank' href=\"$mplink\">$previewtext</a>)";
812812 if( $skinkey == $wgDefaultSkin )
813813 $sn .= ' (' . wfMsg( 'default' ) . ')';
814814 $wgOut->addHTML( "<input type='radio' name='wpSkin' id=\"wpSkin$skinkey\" value=\"$skinkey\"$checked /> <label for=\"wpSkin$skinkey\">{$sn}</label> $previewlink<br />\n" );

Status & tagging log