r44475 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44474‎ | r44475 | r44476 >
Date:23:04, 11 December 2008
Author:vyznev
Status:ok (Comments)
Tags:
Comment:
stricter parsing for readability, reliability and to (hopefully) fix breakage for users that go by their e-mail address only
Modified paths:
  • /trunk/tools/wikibugs/wikibugs (modified) (history)

Diff [purge]

Index: trunk/tools/wikibugs/wikibugs
@@ -55,9 +55,9 @@
5656 $/ = "";
5757 # extract and remove the comment section
5858 my ($haschanges, $user);
59 - my $comment = $contents =~ s/\-+\s*Comment\s#\d+\sfrom\s.*?\s<(.*?)\@.*//s;
 59+ my $comment = $contents =~ s/^--- Comment #\d+ from (?-s:.*?<)?(\S+)\@.*//ms;
6060 if($comment) {
61 - $user = $1;
 61+ $user = $1;
6262 } else {
6363 $user = 'N/A' # shouldn't be possible'
6464 }

Comments

#Comment by Brion VIBBER (talk | contribs)   00:06, 12 December 2008

woohoo!

Status & tagging log