r44472 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r44471‎ | r44472 | r44473 >
Date:21:51, 11 December 2008
Author:catrope
Status:ok (Comments)
Tags:
Comment:
API: (bug 16594) Use strict comparison in list=allusers. This'll hopefully make [[User:]] on enwiki show up again; he's currently being dropped from the user list because false == ''
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryAllUsers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryAllUsers.php
——@@ -121,7 +121,7 @@
122122 $row = $db->fetchObject($res);
123123 $count++;
124124
125 - if (!$row || $lastUser != $row->user_name) {
 125+ if (!$row || $lastUser !== $row->user_name) {
126126 // Save the last pass's user data
127127 if (is_array($lastUserData))
128128 $data[] = $lastUserData;

Comments

#Comment by Brion VIBBER (talk | contribs)   22:47, 11 December 2008

I've deleted the record btw.

Status & tagging log