r44467 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44466‎ | r44467 | r44468 >
Date:20:29, 11 December 2008
Author:ialex
Status:ok
Tags:
Comment:
Per siebrand, added PLURAL support for the following message:
* configure-condition-description-1
* configure-condition-description-2
* configure-condition-description-4
The last one also has a $2 param with the group count
Modified paths:
  • /trunk/extensions/Configure/Configure.diff.php (modified) (history)
  • /trunk/extensions/Configure/Configure.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Configure/Configure.diff.php
@@ -299,7 +299,7 @@
300300 $boolop = array_shift( $conds );
301301 $boolop = $opToName[$boolop];
302302
303 - $val[] = "$group: ".wfMsg( "configure-boolop-description-$boolop" );
 303+ $val[] = "$group: " . wfMsg( "configure-boolop-description-$boolop" );
304304 } else {
305305 $conds = array( $conds );
306306 }
@@ -307,7 +307,7 @@
308308 // Analyse each individual one...
309309 foreach( $conds as $cond ) {
310310 if ($cond == array( APCOND_AGE, -1 ) ) {
311 - $val[] = "$group: ".wfMsg( 'configure-autopromote-noconds' );
 311+ $val[] = "$group: " . wfMsg( 'configure-autopromote-noconds' );
312312 continue;
313313 }
314314
@@ -318,8 +318,9 @@
319319
320320
321321 $argSummary = implode( ', ', $cond );
 322+ $count = count( $cond );
322323
323 - $val[] = "$group: ".wfMsg( "configure-condition-description-$name", $argSummary );
 324+ $val[] = "$group: ".wfMsgExt( "configure-condition-description-$name", array( 'parsemag' ), $argSummary, $count );
324325 }
325326 }
326327 } else {
Index: trunk/extensions/Configure/Configure.i18n.php
@@ -190,7 +190,7 @@
191191 'configure-autopromote-noconds' => 'No prerequisites',
192192
193193 'configure-condition-description-1' => 'Minimum edit count of $1',
194 - 'configure-condition-description-2' => 'Minimum account age of $1 seconds',
 194+ 'configure-condition-description-2' => 'Minimum account age of $1 {{PLURAL:$1|second|seconds}}',
195195 'configure-condition-description-3' => 'Email confirmed',
196196 'configure-condition-description-4' => 'In all of the groups $1',
197197

Status & tagging log