r44466 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44465‎ | r44466 | r44467 >
Date:20:22, 11 December 2008
Author:aaron
Status:deferred
Tags:
Comment:
Remove clutter, explain better
Modified paths:
  • /trunk/extensions/FlaggedRevs/language/RatingHistory.i18n.php (modified) (history)
  • /trunk/extensions/FlaggedRevs/specialpages/RatingHistory_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/language/RatingHistory.i18n.php
@@ -9,8 +9,7 @@
1010
1111 $messages['en'] = array(
1212 'ratinghistory' => 'Page rating history',
13 - 'ratinghistory-text' => '\'\'\'This page displays page rating data for [[:$1|$1]].\'\'\'',
14 - 'ratinghistory-leg' => 'Rating history data',
 13+ 'ratinghistory-leg' => 'Rating history data for [[:$1|$1]]',
1514 'ratinghistory-tab' => 'rating',
1615 'ratinghistory-link' => 'Page rating',
1716 'ratinghistory-thanks' => '\'\'<font color="darkred">Thank you for taking a moment to review this page!</font>\'\'',
@@ -24,7 +23,8 @@
2524 'ratinghistory-graph' => '$2 of "$3" ($1 {{PLURAL:$1|review|reviews}})',
2625 'ratinghistory-none' => 'There is not enough reader feedback data available for graphs at this time.',
2726 'ratinghistory-legend' => 'The \'\'\'daily average rating\'\'\' <font color="blue">\'\'(blue)\'\'</font> and
28 - \'\'\'interval average rating\'\'\' <font color="green">\'\'(green)\'\'</font> are graphed below, by date.
 27+ \'\'\'running average rating\'\'\' <font color="green">\'\'(green)\'\'</font> are graphed below, by date. The
 28+ \'\'\'running average rating\'\'\' is simply the average of all the daily ratings \'\'within\'\' this time frame for each day.
2929
3030 Scale: \'\'\'[1]\'\'\' - Poor; \'\'\'[2]\'\'\' - Low; \'\'\'[3]\'\'\' - Fair; \'\'\'[4]\'\'\' - High; \'\'\'[5]\'\'\' - Excellent;
3131
Index: trunk/extensions/FlaggedRevs/specialpages/RatingHistory_body.php
@@ -53,7 +53,6 @@
5454 if( ReaderFeedback::userAlreadyVoted( $this->page ) ) {
5555 $wgOut->setSubtitle( wfMsgExt('ratinghistory-thanks','parse') );
5656 }
57 - $this->showLead();
5857 $this->showForm();
5958 $this->showHeader();
6059 /*
@@ -67,20 +66,17 @@
6867 $this->showGraphs();
6968 }
7069
71 - protected function showLead() {
72 - global $wgOut;
73 - $wgOut->addWikiText( wfMsg('ratinghistory-text',$this->page->getPrefixedText()) );
74 - }
75 -
7670 protected function showHeader() {
7771 global $wgOut;
78 - $wgOut->addWikiText( wfMsg('ratinghistory-legend', $this->dScale) );
 72+ $wgOut->addWikiText( wfMsg('ratinghistory-legend',$this->dScale) );
7973 }
8074
8175 protected function showForm() {
8276 global $wgOut, $wgTitle, $wgScript;
8377 $form = Xml::openElement( 'form', array( 'name' => 'reviewedpages', 'action' => $wgScript, 'method' => 'get' ) );
84 - $form .= "<fieldset><legend>".wfMsg('ratinghistory-leg')."</legend>\n";
 78+ $form .= "<fieldset>";
 79+ $form .= "<legend>".wfMsgExt('ratinghistory-leg',array('parseinline'),
 80+ $this->page->getPrefixedText())."</legend>\n";
8581 $form .= Xml::hidden( 'title', $wgTitle->getPrefixedDBKey() );
8682 $form .= Xml::hidden( 'target', $this->page->getPrefixedDBKey() );
8783 $form .= $this->getPeriodMenu( $this->period );

Status & tagging log