r44462 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44461‎ | r44462 | r44463 >
Date:19:31, 11 December 2008
Author:aaron
Status:ok (Comments)
Tags:
Comment:
(bug 16445) Use more obvious text than *
Modified paths:
  • /trunk/extensions/CheckUser/CheckUser.i18n.php (modified) (history)
  • /trunk/extensions/CheckUser/CheckUser_body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CheckUser/CheckUser_body.php
@@ -816,10 +816,6 @@
817817 # Load user object
818818 $user = User::newFromName( $name, false );
819819 $authUser = $wgAuth->getUserInstance( $user );
820 - # Show if account is local only
821 - if( $authUser->getId() === 0 ) {
822 - $s .= '*';
823 - }
824820 # Add user tool links
825821 $s .= $this->sk->userLink( -1 , $name ) . $this->sk->userToolLinks( -1 , $name );
826822 # Add CheckUser link
@@ -866,6 +862,10 @@
867863 'type=block&page=' . urlencode( $userpage->getPrefixedText() ) );
868864 $flags[] = '<strong>(' . $blocklog . ')</strong>';
869865 }
 866+ # Show if account is local only
 867+ if( $authUser->getId() === 0 ) {
 868+ $flags[] = '<strong>(' . wfMsgHtml('checkuser-localonly') . ')</strong>';
 869+ }
870870 # Check for extra user rights...
871871 if( $users_ids[$name] ) {
872872 $user = User::newFromId( $users_ids[$name] );
Index: trunk/extensions/CheckUser/CheckUser.i18n.php
@@ -46,6 +46,7 @@
4747 'checkuser-gblocked' => 'Blocked globally',
4848 'checkuser-locked' => 'Locked',
4949 'checkuser-wasblocked' => 'Previously blocked',
 50+ 'checkuser-localonly' => 'Not unified',
5051 'checkuser-massblock' => 'Block selected users',
5152 'checkuser-massblock-text' => 'Selected accounts will be blocked indefinitely, with autoblocking enabled and account creation disabled.
5253 IP addresses will be blocked for 1 week for IP users only and with account creation disabled.',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r43990(bug 16445) add info if accounts are not sul accounts to cu resultsaaron07:45, 27 November 2008

Comments

#Comment by Brion VIBBER (talk | contribs)   19:36, 11 December 2008

w00t

Status & tagging log