r44437 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44436‎ | r44437 | r44438 >
Date:00:29, 11 December 2008
Author:brion
Status:ok
Tags:
Comment:
Revert r44335 "Tweak profile calls"
Let the doUpdates() func get counted even when it has nothing to do; otherwise stats will be skewed to only times when there are multiple updates. Or.... hmmm. bleah.
Modified paths:
  • /trunk/phase3/includes/Wiki.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Wiki.php
@@ -343,11 +343,13 @@
344344 * @param $updates array of objects that hold an update to do
345345 */
346346 function doUpdates( &$updates ) {
 347+ wfProfileIn( __METHOD__ );
347348 /* No need to get master connections in case of empty updates array */
348 - if( !$updates ) {
 349+ if (!$updates) {
 350+ wfProfileOut( __METHOD__ );
349351 return;
350352 }
351 - wfProfileIn( __METHOD__ );
 353+
352354 $dbw = wfGetDB( DB_MASTER );
353355 foreach( $updates as $up ) {
354356 $up->doUpdate();

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r44335Tweak profile callsaaron11:51, 9 December 2008

Status & tagging log