r44335 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44334‎ | r44335 | r44336 >
Date:11:51, 9 December 2008
Author:aaron
Status:reverted (Comments)
Tags:
Comment:
Tweak profile calls
Modified paths:
  • /trunk/phase3/includes/Wiki.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Wiki.php
@@ -351,13 +351,11 @@
352352 * @param $updates array of objects that hold an update to do
353353 */
354354 function doUpdates( &$updates ) {
355 - wfProfileIn( __METHOD__ );
356355 /* No need to get master connections in case of empty updates array */
357 - if (!$updates) {
358 - wfProfileOut( __METHOD__ );
 356+ if( !$updates ) {
359357 return;
360358 }
361 -
 359+ wfProfileIn( __METHOD__ );
362360 $dbw = wfGetDB( DB_MASTER );
363361 foreach( $updates as $up ) {
364362 $up->doUpdate();

Follow-up revisions

RevisionCommit summaryAuthorDate
r44437Revert r44335 "Tweak profile calls"...brion00:29, 11 December 2008

Comments

#Comment by Brion VIBBER (talk | contribs)   00:30, 11 December 2008

Reverted in r44437; this seems to alter the data by dropping cases where there's no work to do in the func?

Status & tagging log