| Index: trunk/phase3/includes/ChangesList.php |
| — | — | @@ -339,6 +339,7 @@ |
| 340 | 340 | wfProfileIn( __METHOD__ ); |
| 341 | 341 | |
| 342 | 342 | # Extract DB fields into local scope |
| | 343 | + // FIXME: Would be good to replace this extract() call with something that explicitly initializes local variables. |
| 343 | 344 | extract( $rc->mAttribs ); |
| 344 | 345 | |
| 345 | 346 | # Should patrol-related stuff be shown? |
| — | — | @@ -432,6 +433,7 @@ |
| 433 | 434 | $rc = RCCacheEntry::newFromParent( $baseRC ); |
| 434 | 435 | |
| 435 | 436 | # Extract fields from DB into the function scope (rc_xxxx variables) |
| | 437 | + // FIXME: Would be good to replace this extract() call with something that explicitly initializes local variables. |
| 436 | 438 | extract( $rc->mAttribs ); |
| 437 | 439 | $curIdEq = 'curid=' . $rc_cur_id; |
| 438 | 440 | |
| — | — | @@ -720,6 +722,7 @@ |
| 721 | 723 | $r .= '<table cellpadding="0" cellspacing="0" border="0" style="background: none">'; |
| 722 | 724 | foreach( $block as $rcObj ) { |
| 723 | 725 | # Get rc_xxxx variables |
| | 726 | + // FIXME: Would be good to replace this extract() call with something that explicitly initializes local variables. |
| 724 | 727 | extract( $rcObj->mAttribs ); |
| 725 | 728 | |
| 726 | 729 | #$r .= '<tr><td valign="top">'.$this->spacerArrow(); |
| — | — | @@ -839,6 +842,7 @@ |
| 840 | 843 | protected function recentChangesBlockLine( $rcObj ) { |
| 841 | 844 | global $wgContLang, $wgRCShowChangedSize; |
| 842 | 845 | # Get rc_xxxx variables |
| | 846 | + // FIXME: Would be good to replace this extract() call with something that explicitly initializes local variables. |
| 843 | 847 | extract( $rcObj->mAttribs ); |
| 844 | 848 | $curIdEq = "curid={$rc_cur_id}"; |
| 845 | 849 | |