r44381 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r44380‎ | r44381 | r44382 >
Date:04:40, 10 December 2008
Author:aaron
Status:reverted (Comments)
Tags:
Comment:
Remove noisy profiling
Modified paths:
  • /trunk/phase3/includes/Wiki.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Wiki.php
@@ -50,7 +50,6 @@
5151 * @param $request WebRequest
5252 */
5353 function initialize( &$title, &$article, &$output, &$user, $request ) {
54 - wfProfileIn( __METHOD__ );
5554 $this->preliminaryChecks( $title, $output, $request ) ;
5655 if( !$this->initializeSpecialCases( $title, $output, $request ) ) {
5756 $new_article = $this->initializeArticle( $title, $request );
@@ -60,11 +59,9 @@
6160 } elseif( is_string( $new_article ) ) {
6261 $output->redirect( $new_article );
6362 } else {
64 - wfProfileOut( __METHOD__ );
6563 throw new MWException( "Shouldn't happen: MediaWiki::initializeArticle() returned neither an object nor a URL" );
6664 }
6765 }
68 - wfProfileOut( __METHOD__ );
6966 }
7067
7168 /**
@@ -132,7 +129,6 @@
133130 * @param $request WebRequest
134131 */
135132 function preliminaryChecks( &$title, &$output, $request ) {
136 -
137133 if( $request->getCheck( 'search' ) ) {
138134 // Compatibility with old search URLs which didn't use Special:Search
139135 // Just check for presence here, so blank requests still
@@ -141,7 +137,6 @@
142138 // Do this above the read whitelist check for security...
143139 $title = SpecialPage::getTitleFor( 'Search' );
144140 }
145 -
146141 # If the user is not logged in, the Namespace:title of the article must be in
147142 # the Read array in order for the user to see it. (We have to check here to
148143 # catch special pages etc. We check again in Article::view())
@@ -150,7 +145,6 @@
151146 $output->output();
152147 exit;
153148 }
154 -
155149 }
156150
157151 /**
@@ -418,10 +412,7 @@
419413 * @param $request WebRequest
420414 */
421415 function performAction( &$output, &$article, &$title, &$user, &$request ) {
422 - wfProfileIn( __METHOD__ );
423 -
424416 if( !wfRunHooks( 'MediaWikiPerformAction', array( $output, $article, $title, $user, $request, $this ) ) ) {
425 - wfProfileOut( __METHOD__ );
426417 return;
427418 }
428419
@@ -512,7 +503,6 @@
513504 $output->showErrorPage( 'nosuchaction', 'nosuchactiontext' );
514505 }
515506 }
516 - wfProfileOut( __METHOD__ );
517507
518508 }
519509

Follow-up revisions

RevisionCommit summaryAuthorDate
r44439Revert r44381 "Remove noisy profiling"...brion00:54, 11 December 2008

Comments

#Comment by Brion VIBBER (talk | contribs)   00:56, 11 December 2008

Reverted in r44439... we like profiling? :D

Status & tagging log